Skip to content

Add Pause Splash Screen Tooltip and Run Preview Tooltip#13904

Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom
jesusalvino:DYN-5721-PreferencesPanel-Icons
Apr 17, 2023
Merged

Add Pause Splash Screen Tooltip and Run Preview Tooltip#13904
QilongTang merged 1 commit intoDynamoDS:masterfrom
jesusalvino:DYN-5721-PreferencesPanel-Icons

Conversation

@jesusalvino
Copy link
Contributor

@jesusalvino jesusalvino commented Apr 15, 2023 •
edited
Loading

Purpose

Implementing the improvement https://jira.autodesk.com/browse/DYN-5721

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Reviewers

@QilongTang

FYIs

@RobertGlobant20
@Enzo707

@jesusalvino
Copy link
Contributor Author

jesusalvino commented Apr 15, 2023

pref-tooltips

@zeusongit
Copy link
Contributor

zeusongit commented Apr 16, 2023

Does this work with localized strings? Can you test that as well?

@QilongTang QilongTang added this to the 2.18.0 milestone Apr 17, 2023
@QilongTang
Copy link
Contributor

QilongTang commented Apr 17, 2023

Does this work with localized strings? Can you test that as well?

Do you mean when the tooltip is localized?

@zeusongit
Copy link
Contributor

zeusongit commented Apr 17, 2023

Does this work with localized strings? Can you test that as well?

Do you mean when the tooltip is localized?

No I mean when the preference option is localized, I saw some examples where when localized the location of the question mark will not change while the string is now longer than it is in English.

@QilongTang
Copy link
Contributor

QilongTang commented Apr 17, 2023

Does this work with localized strings? Can you test that as well?

Do you mean when the tooltip is localized?

No I mean when the preference option is localized, I saw some examples where when localized the location of the question mark will not change while the string is now longer than it is in English.

Gotcha, do you recall which ones? I guess for @jesusalvino Please just sanity check other languages to see if the position is good

@zeusongit
Copy link
Contributor

zeusongit commented Apr 17, 2023

Does this work with localized strings? Can you test that as well?

Do you mean when the tooltip is localized?

No I mean when the preference option is localized, I saw some examples where when localized the location of the question mark will not change while the string is now longer than it is in English.

Gotcha, do you recall which ones? I guess for @jesusalvino Please just sanity check other languages to see if the position is good

German / de-DE

@reddyashish
Copy link
Collaborator

reddyashish commented Apr 17, 2023 •
edited
Loading

@Jingyi-Wen Looks like there is extra space between the label name and the icon. Probably reduce that a little? Also the icon is not center-aligned vertically in some cases.

@QilongTang
Copy link
Contributor

QilongTang commented Apr 17, 2023

@Jingyi-Wen Looks like there is extra space between the label name and the icon. Probably reduce that a little? Also the icon is not center-aligned vertically in some cases.

Make sense, let's get this in now for 2.18 and work within team in bug bashes to see what needs to be adjusted

@jesusalvino
Copy link
Contributor Author

jesusalvino commented Apr 17, 2023

de-DE lang looks good IMHO

image

@QilongTang QilongTang merged commit 42a806a into DynamoDS:master Apr 17, 2023
@Jingyi-Wen
Copy link

Jingyi-Wen commented Apr 18, 2023

@Jingyi-Wen Looks like there is extra space between the label name and the icon. Probably reduce that a little? Also the icon is not center-aligned vertically in some cases.

Good catch! We definitely should have them center-aligned vertically. And agree with reducing the space, the icon next to the Max Number of Recent Files text box is a good reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

@zeusongit zeusongit zeusongit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.18.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jesusalvino @zeusongit @QilongTang @reddyashish @Jingyi-Wen