Handle PortToConnect correctly, when same node recommendations are returned from ML API#13899
Merged
QilongTang merged 4 commits intoDynamoDS:masterfrom Apr 18, 2023
Merged
Conversation
…turned from ML API
Closed
9 tasks
Contributor
|
Hi @reddyashish Is this PR just for the bug that clicking on each entry will connect to the right port instead? you mentioned that we cant implement the UI changes for sub menu items correct? |
Collaborator
Author
|
Yes, just for that bug. |
1 similar comment
Collaborator
Author
|
Yes, just for that bug. |
Collaborator
Author
|
@QilongTang Only 1 flaky test now InsideCustomNode_NotPlacedInHomeWorkspace_NoGeometry. |
Contributor
|
@reddyashish And we are still not sure which PR caused that flaky test right? Are you fine with Morpheus team merging PRs with new flaky tests? @mjkkirschner @sm6srw or would you rather us investigate this a bit more? |
Collaborator
Author
|
Yeah not sure yet. Lets see the results from Mike's PR #13900, if any test fails |
QilongTang
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-5645
Now the correct port is connected when same node recommendations are returned from ML API. The results are displayed as list box and not as menu items. So we won't be able to provide sub menu functionality.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Handle PortToConnect correctly, when same node recommendations are returned from ML API
Reviewers
@QilongTang
FYIs
@DynamoDS/dynamo