DYN-5652: Update internals visibility for Dynamo Player rewrite#13889
Merged
QilongTang merged 1 commit intomasterfrom Apr 11, 2023
Merged
DYN-5652: Update internals visibility for Dynamo Player rewrite#13889QilongTang merged 1 commit intomasterfrom
QilongTang merged 1 commit intomasterfrom
Conversation
076bb9e to
3d715f9
Compare
QilongTang
approved these changes
Apr 10, 2023
Contributor
|
hi @twastvedt Just to confirm, this is for upcoming 2.18 release right? |
Contributor
Author
|
Hi @QilongTang. It would be helpful if it was in 2.18 so we can start testing Player with the new project names without needing a dev build of Dynamo. We won't be releasing with these new names until 2.19 though. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
DYN-5652 - This PR updates the list of assembly names which have access to Dynamo Core internal types to include the new assembly names from the rewrite of Dynamo Player to use the new API.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Update internals visibility for Dynamo Player rewrite.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
@saintentropy @BogdanZavu