DYN-5755 : restrict logging in service mode#13860
DYN-5755 : restrict logging in service mode#13860mjkkirschner merged 2 commits intoDynamoDS:masterfrom
Conversation
|
|
||
| notifications = new List<NotificationMessage>(); | ||
|
|
||
| testMode = isTestMode; |
There was a problem hiding this comment.
we should merge all these flags somehow at some point
There was a problem hiding this comment.
If you throw in an obsolete message and a TODO + Dynamo 3.0 it will be easier to find later when we want to refactor all these signatures throughout the code base.
|
hey @BogdanZavu there is one unusual failing test: can you try it locally? Unfortunately the build machines seem to be down so I can't kick off another rebuild to see if it's intermittent, I will look into that - also will review. |
| protected void SaveBackupFiles(object state) | ||
| { | ||
| //No backup files in ServiceMode due to Lambda restrictions | ||
| if (IsServiceMode) |
There was a problem hiding this comment.
would be nice to have a test for this if there are already backup tests
mjkkirschner
left a comment
mjkkirschner
left a comment
There was a problem hiding this comment.
looks good but a few comments
* restrict logging in service mode * add todo --------- Co-authored-by: Bogdan Zavu <[email protected]> passed.
4 participants
Purpose
We have to deal with some limitations when we deploy Dynamo in service mode.
More precisely there are restrictions when running Dynamo in a Lambda and we can't create local files.
Declarations
Check these if you believe they are true
*.resxfiles