ALSO-5603 Hide missing ML complete controls if hiding option is set#13859
Merged
sm6srw merged 1 commit intoDynamoDS:masterfrom Mar 31, 2023
Merged
ALSO-5603 Hide missing ML complete controls if hiding option is set#13859sm6srw merged 1 commit intoDynamoDS:masterfrom
sm6srw merged 1 commit intoDynamoDS:masterfrom
Conversation
8 tasks
Contributor
|
@QilongTang This looks good to me. Can you also take a quick look? |
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 31, 2023
QilongTang
pushed a commit
that referenced
this pull request
Mar 31, 2023
* ALSO-5603 Add parameter hiding autocomplete options from the UI (#13834) * ALSO-5603 Add parameter hiding autocomplete options from the UI * ALSO-5603 Use IPreferences for hide autocomplete option This needs to avoid breaking compatibility * ALSO-5603 Add hide autocomplete option to the settings * ALSO-5603 Fix unit test * ALSO-5603 Hide missing ML complete controls if hiding option is set (#13859) --------- Co-authored-by: spodo99 <[email protected]>
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Original PR adding HideAutocompleteMethodOptions was there #13834
This PR hides controls corresponding to ML Autocomplete feature which were missing in the first PR.
Conversation at https://autodesk.slack.com/archives/C1866AFQB/p1679067914031959
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of