Bugfix - Live Chart Nodes Search Tags#13843
Merged
reddyashish merged 3 commits intoDynamoDS:masterfrom Mar 24, 2023
Merged
Conversation
reddyashish
reviewed
Mar 22, 2023
src/Libraries/CoreNodeModelsWpf/Properties/CoreNodeModelWpfResources.en-US.resx
Outdated
Show resolved
Hide resolved
reddyashish
approved these changes
Mar 22, 2023
Contributor
|
@reddyashish Side question, are search tags put into resources so that they can be surfaced in a localized env? |
Collaborator
Author
The search tags are in resources @QilongTang , yes! |
Member
Collaborator
Author
This test is passing locally. I tried rebuilding the PR, but it popped up with 2 more failing tests. I might get a new PR from scratch based on the latest Dynamo build. |
Member
reddyashish
approved these changes
Mar 24, 2023
Collaborator
reddyashish
left a comment
reddyashish
left a comment
There was a problem hiding this comment.
Will merge once the self-serve finishes
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 29, 2023
* Bugfix - search tags were duplicating the alsoknownas property causing an error to be thrown * Remove code that should not be part of the PR
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
* Bugfix - search tags were duplicating the alsoknownas property causing an error to be thrown * Remove code that should not be part of the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A small PR modifying the Search Tags of a series of Nodes.
The recently added Live Chart nodes had duplicate information in Search Tags and the AlsoKnownAs node properties, which was causing an error to be thrown when adding the node information to the Search Dictionary. Changing the Search Tags solved this issue.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
search tagswere duplicating thealsoknownasproperty causing an error to be thrownReviewers
@mjkkirschner
@reddyashish
FYIs
@Amoursol