Dyn 5676 color picker custom colors popup#13824
Merged
QilongTang merged 4 commits intoDynamoDS:masterfrom Mar 16, 2023
RobertGlobant20:DYN-5676-ColorPicker-CustomColorsPopup
Merged
Dyn 5676 color picker custom colors popup#13824QilongTang merged 4 commits intoDynamoDS:masterfrom RobertGlobant20:DYN-5676-ColorPicker-CustomColorsPopup
QilongTang merged 4 commits intoDynamoDS:masterfrom
RobertGlobant20:DYN-5676-ColorPicker-CustomColorsPopup
Conversation
- I've added the controls for selecting the custom colors. - I've modified to current CustomColorPicker to use just one Popup. - I've modified the code for creating the CustomColorPicker so now we will be passing the list of custom colors and the initial color that will be selected (in case it exist in the ColorPicker).
Updating the Style for the ToggleButton inside the Color Palette node due that was not following the Visual Refresh style used in other ComboBoxes
Contributor
Author
|
Here is a GIF showing the behavior of the CustomColorPicker when selecting a color in the GroupStyles section. |
Contributor
Author
|
Here is a GIF showing the behavior of the CustomColorPicker when selecting a color in the Color Palette node. |
Contributor
Author
|
Here is a GIF showing the Color Palette node with the ToggleButton using the updated Style. |
QilongTang
reviewed
Mar 15, 2023
| d:DesignHeight="550" | ||
| d:DesignWidth="800" | ||
| AllowsTransparency="True" | ||
| Focusable="False" |
Contributor
There was a problem hiding this comment.
what does this doe? I guess the focus will remain on Dynamo window?
Contributor
Author
There was a problem hiding this comment.
@QilongTang I changed this property to True so it will have the focus when the Popup is opened.
See the next commit: ada8c38
QilongTang
approved these changes
Mar 15, 2023
Setting the property Focusable="True" so it can have the focus when is opened.
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 29, 2023
* DYN-5676-ColorPicker-CustomColorsPopup - I've added the controls for selecting the custom colors. - I've modified to current CustomColorPicker to use just one Popup. - I've modified the code for creating the CustomColorPicker so now we will be passing the list of custom colors and the initial color that will be selected (in case it exist in the ColorPicker). * DYN-5676-ColorPicker-CustomColorsPopup Updating the Style for the ToggleButton inside the Color Palette node due that was not following the Visual Refresh style used in other ComboBoxes * DYN-5676-ColorPicker-CustomColorsPopup Code Review1 Setting the property Focusable="True" so it can have the focus when is opened.
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
* DYN-5676-ColorPicker-CustomColorsPopup - I've added the controls for selecting the custom colors. - I've modified to current CustomColorPicker to use just one Popup. - I've modified the code for creating the CustomColorPicker so now we will be passing the list of custom colors and the initial color that will be selected (in case it exist in the ColorPicker). * DYN-5676-ColorPicker-CustomColorsPopup Updating the Style for the ToggleButton inside the Color Palette node due that was not following the Visual Refresh style used in other ComboBoxes * DYN-5676-ColorPicker-CustomColorsPopup Code Review1 Setting the property Focusable="True" so it can have the focus when is opened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Several changes were done for supporting the Custom Color controls in the CustomColorPicker Popup, here is the list of the most important changes:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Several changes were done for supporting the Custom Color controls in the CustomColorPicker Popup
Reviewers
@QilongTang
FYIs
@avidit
@Jingyi-Wen