Conversation
| Sequence = jsonStepInfo.Sequence, | ||
| RatingTextTitle = formattedText.ToString(), | ||
| StepType = Step.StepTypes.SURVEY, | ||
| IsRatingVisible = dynamoViewModel.Model.PreferenceSettings.IsADPAnalyticsReportingApproved, |
There was a problem hiding this comment.
@mjkkirschner @QilongTang any ideas what this is used for ?
There was a problem hiding this comment.
This is about the five star rating after guided tour exited, when analytics opt-in, we display the rating for ppl to rate
There was a problem hiding this comment.
well now we will no longer know if ADP is opted in or not.
Should I just check for google analytics ? or as it is (if no one explicitly disabled analytics) ?
There was a problem hiding this comment.
I would leave it as it is in your PR. It seems after this change, only startup params would impact which I think should still apply. The worst case is user clicked rating but both GA and ADP Opt-out, and client sends nothing?
| RatingTextTitle = formattedText.ToString(), | ||
| StepType = Step.StepTypes.SURVEY, | ||
| IsRatingVisible = dynamoViewModel.Model.PreferenceSettings.IsADPAnalyticsReportingApproved, | ||
| IsRatingVisible = !Analytics.DisableAnalytics && Analytics.IsEnabled, |
There was a problem hiding this comment.
will Analytics.IsEnabled always be true?
There was a problem hiding this comment.
IsEnabled is false when the DynamoAnalyticsClient is not created. DynamoAnalyticsClient is created when dynamo model is started with these flags
!IsServiceMode && !areAnalyticsDisabledFromConfig && !Dynamo.Logging.Analytics.DisableAnalytics
There was a problem hiding this comment.
There might be some other conditions that affect if DynamoAnalyticsClient is created (depending on how the Dynamo model is created)
* update analytics * Update DynamoCore.csproj * Update DynamoCoreTests.csproj --------- Co-authored-by: pinzart <[email protected]>
* update analytics * Update DynamoCore.csproj * Update DynamoCoreTests.csproj --------- Co-authored-by: pinzart <[email protected]>
3 participants
Remove all usage of IsOptedIn for ADP (it is considered an internal API by ADP)
Added
USEEXCEPTIONTRACEoption for CER as per this discussion https://autodesk.slack.com/archives/CH8CL3MRR/p1664815775433379