Merged
Conversation
mjkkirschner
reviewed
Mar 7, 2023
src/DynamoCore/DynamoCore.csproj
Outdated
| <PackageReference Include="Greg" Version="2.3.0.2505" /> | ||
| <PackageReference Include="Newtonsoft.Json" Version="13.0.1" CopyXML="true" /> | ||
| <PackageReference Include="RestSharp" Version="106.12.0" CopyXML="true" /> | ||
| <Reference Include="System.Collections.Immutable"> |
Member
There was a problem hiding this comment.
it looks quite strange - it's a reference to System.Collections.Immutable - but pointing at Protogeometry?
Contributor
Author
There was a problem hiding this comment.
That was supposed to be ProtoGeometry
Contributor
Author
There was a problem hiding this comment.
Ugh..I see now that indirect references are not turned on..
mjkkirschner
reviewed
Mar 7, 2023
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <LibGInterface Include="$(PkgDynamoVisualProgramming_LibG_229_0_0)\tools\netstandard2.0\LibG.Interface.dll" /> | ||
| <LibGProtoGeometryXml Include="$(PkgDynamoVisualProgramming_LibG_229_0_0)\lib\netstandard2.0\ProtoGeometry.XML" /> |
Member
There was a problem hiding this comment.
was the package layout modified?
Contributor
Author
There was a problem hiding this comment.
yes
I had to add both windows and linux flavors of all binaries (including managed)
Member
|
@pinzart90 something still seems wrong as all PR check builds are failing. |
mjkkirschner
reviewed
Mar 8, 2023
| <Copy SourceFiles="@(LibGProtoGeometryXml)" DestinationFolder="$(OutputPath)" /> | ||
| <Copy SourceFiles="@(LibGProtoGeometryXml)" DestinationFolder="$(OutputPath)\$(UICulture)" /> | ||
| <Copy SourceFiles="@(LibGProtoGeometryUICulture)" DestinationFolder="$(OutputPath)\$(UICulture)" /> | ||
| <Copy Condition="$(Platform.Contains('Linux'))" SourceFiles="@(LibG229Deps)" DestinationFolder="$(OutputPath)libg_228_0_0\asm_deps\" /> |
mjkkirschner
approved these changes
Mar 8, 2023
Contributor
Author
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 29, 2023
* update libg * Update DynamoCore.csproj * Update DynamoCore.csproj * Update DynamoCore.csproj * update * Update DynamoCore.csproj * update * Update Utilities.cs --------- Co-authored-by: pinzart <[email protected]>
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
* update libg * Update DynamoCore.csproj * Update DynamoCore.csproj * Update DynamoCore.csproj * update * Update DynamoCore.csproj * update * Update Utilities.cs --------- Co-authored-by: pinzart <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update libg package references to include the latest linux binaries
Purpose
(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of