Enable Locale Selection in Dynamo Preferences Panel#13802
Merged
QilongTang merged 14 commits intomasterfrom Mar 9, 2023
Merged
Enable Locale Selection in Dynamo Preferences Panel#13802QilongTang merged 14 commits intomasterfrom
QilongTang merged 14 commits intomasterfrom
Conversation
reddyashish
reviewed
Mar 8, 2023
reddyashish
reviewed
Mar 8, 2023
RobertGlobant20
approved these changes
Mar 8, 2023
Contributor
RobertGlobant20
left a comment
There was a problem hiding this comment.
LGTM with one comment
mjkkirschner
reviewed
Mar 8, 2023
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 29, 2023
* First Commit * Update locale on startup * spelling * dynamically display and select current locale * Clean up * Unit Tests * Add toast notification * Move constants out of PreferencesSetting object * Add info icon and tooltip * Update PreferenceSettingsTests.cs * Update test file * Remove interface change
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
* First Commit * Update locale on startup * spelling * dynamically display and select current locale * Clean up * Unit Tests * Add toast notification * Move constants out of PreferencesSetting object * Add info icon and tooltip * Update PreferenceSettingsTests.cs * Update test file * Remove interface change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
This PR enables Locale selection in Dynamo Preferences Panel. As a result, Dynamo will be localized in the new locale after a restart. Notice that the selection does not affect current Dynamo session.
User experience: (notice the new language selections resources are in DynamoCore not localized yet)

New info icon added
Toast notification added

Gif:

Serialization changes:

TODO:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Enable Locale Selection in Dynamo Preferences Panel
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of