Enable python zoom scale in Dynamo Preferences Panel#13798
Merged
QilongTang merged 16 commits intoDynamoDS:masterfrom Mar 9, 2023
Merged
Enable python zoom scale in Dynamo Preferences Panel#13798QilongTang merged 16 commits intoDynamoDS:masterfrom
QilongTang merged 16 commits intoDynamoDS:masterfrom
Conversation
QilongTang
reviewed
Mar 3, 2023
QilongTang
reviewed
Mar 3, 2023
QilongTang
reviewed
Mar 3, 2023
QilongTang
reviewed
Mar 3, 2023
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with a couple comments
QilongTang
changed the title
QilongTang
reviewed
Mar 8, 2023
| </StackPanel> | ||
| <StackPanel Margin="-10,5,0,0" Orientation="Horizontal" Grid.Row="2"> | ||
| <Label Content="0%" | ||
| <Label Content="{x:Static p:Resources.PreferencesViewZoomScaling0Percent}" |
Contributor
There was a problem hiding this comment.
localized instead of hardcode
zeusongit
reviewed
Mar 8, 2023
zeusongit
approved these changes
Mar 9, 2023
reddyashish
reviewed
Mar 9, 2023
reddyashish
reviewed
Mar 9, 2023
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 29, 2023
* python zoom scale * python zoom scale preference settings * fix old comments * remove unused variables * tooltip localization * Comments * updates * clean up * update * Update Python Editor Label * Update test * Comments --------- Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]>
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
* python zoom scale * python zoom scale preference settings * fix old comments * remove unused variables * tooltip localization * Comments * updates * clean up * update * Update Python Editor Label * Update test * Comments --------- Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Per https://jira.autodesk.com/browse/DYN-5531, It is included in this PR the functionality for the Python Zoom Scale setting.
22% is the default scale of python editor similar to previous states
Users can now manipulate zoom scale both in python editor using ctrl + scrolling or in Preferences -> Visual settings -> Zoom Scalling (see below)
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@RobertGlobant20 @jesusalvino