LiveCharts Tooltip Update#13776
Merged
reddyashish merged 22 commits intoDynamoDS:masterfrom Mar 31, 2023
Merged
Conversation
- updated the in-depth description of the Index-Value Line Plot chart
- updated live charts input and ouptut tooltip for all charts
QilongTang
reviewed
Feb 24, 2023
- rework of inport and outport tooltip messages from strings to resources
- wip for default values
- now will output default values to go with the image of the chart - adjusted outputs of some of the nodes - changed resource strings accordingly
Contributor
|
@dnenov LGTM! The only remaining thing would be the blue bar vertically outside the node bounds which indicates that default values are assigned 😊 Is that possible to do, or too hard for UI nodes? |
- the logic is not very clear, still working through it
WIP CHANGES ONLY FOR THE XYLineChartControl for now! The rest of the LiveCharts to follow after approving this one - fixed a serious issue causing Dynamo to freeze because of a deadlock - the issue was caused by the Info state of the node interaction inside the DataBridgeCallback - minor addition to the chart node view - now restricts the minimum size to which the user can resize the window
- now checks all conditions and combinations of port values - OK - all ports correct values, no ports - default values, label and value ports correct values + default colors - Warning - all ports provided but mismatching lists - Warning - all ports, but wrong port type - No Warning, no run - missing ports
- fixed x-values, y-values port names
- fixed a state where the UI would not go back to default state if initialized with null data (after save/open), or would retain default data on UI when wrong/incomplete values were provided to the Node
- moved viewmodel properties initialization up before calling the view to prevent null values - correctly checks for null and empty lists before initializing to allow proper initialization with empty series
- following XYLineChart and ScatterPlot now fixed all connectivity issues with the Heat Series
- a follow up for Bar Chart
- follow up with basic line chart
- finally the changes of pie chart
- detailed live chart tests to cover a lot more use cases and interactions - modified ClearInfoMessages API - now removes `info` state if node is in it
reddyashish
reviewed
Mar 24, 2023
src/Libraries/CoreNodeModelsWpf/Properties/CoreNodeModelWpfResources.resx
Outdated
Show resolved
Hide resolved
Collaborator
|
Build is failing on master-5. Is it building fine locally? |
reddyashish
reviewed
Mar 24, 2023
Collaborator
|
Making this as a draft for now, till we figure out the failing tests |
- manually recovered lost resources after merge
Collaborator
|
Job is running fine now: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/8788/ with one flaky failing test. |
QilongTang
approved these changes
Mar 31, 2023
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
* Updated Index-Value Line description - updated the in-depth description of the Index-Value Line Plot chart * Updated outport tooltipl - updated live charts input and ouptut tooltip for all charts * Port Description to Resources - rework of inport and outport tooltip messages from strings to resources * Default Values Part 1 - wip for default values * Default values functional - now will output default values to go with the image of the chart - adjusted outputs of some of the nodes - changed resource strings accordingly * Port logic, warning and info logic WIP - the logic is not very clear, still working through it * Port interaction bugfix, min size for chart node WIP CHANGES ONLY FOR THE XYLineChartControl for now! The rest of the LiveCharts to follow after approving this one - fixed a serious issue causing Dynamo to freeze because of a deadlock - the issue was caused by the Info state of the node interaction inside the DataBridgeCallback - minor addition to the chart node view - now restricts the minimum size to which the user can resize the window * All conditions satisfied - now checks all conditions and combinations of port values - OK - all ports correct values, no ports - default values, label and value ports correct values + default colors - Warning - all ports provided but mismatching lists - Warning - all ports, but wrong port type - No Warning, no run - missing ports * Fixed inport names - fixed x-values, y-values port names * Rework of default and update of UI control - fixed a state where the UI would not go back to default state if initialized with null data (after save/open), or would retain default data on UI when wrong/incomplete values were provided to the Node * Fix null checks - moved viewmodel properties initialization up before calling the view to prevent null values - correctly checks for null and empty lists before initializing to allow proper initialization with empty series * Heat Series Fixed - following XYLineChart and ScatterPlot now fixed all connectivity issues with the Heat Series * BarChart fixed - a follow up for Bar Chart * Basic Line Chart fix - follow up with basic line chart * Pie Chart fix - finally the changes of pie chart * Added live chart test conditions - detailed live chart tests to cover a lot more use cases and interactions - modified ClearInfoMessages API - now removes `info` state if node is in it * Recover lost resources - manually recovered lost resources after merge * Fix resources en-US file * Add failure category to live chart tests * Fix live chart tests --------- Co-authored-by: reddyashish <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A
smallPR that with updates to inport and outport tooltips for Live Chart nodes to follow the common pattern displaying the type of value associated with the port.Also fixes a number of inconsistent port input combinations and behaviors.
WIP - Ports Interaction and Combinations
Heat Series
Pie Chart
Scatter Plot
XY Line
Basic Line Chart
Bar Chart
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@sm6srw
FYIs
@Amoursol
@hwahlstrom