Support Net6 target for DynamoCoreTests.dll (WIP for feedback) by mjkkirschner · Pull Request #13766 · DynamoDS/Dynamo

mjkkirschner · 2023-02-21T22:10:00Z

Purpose

This PR starts to move tests in DynamoCoreTests to .NET6.

It's still a WIP - but I think it's ready for feedback.

does the following:

even though tests now build on linux- testing on github action is still blocked - I filed dotnet test on linux fails to find tests microsoft/vstest#4330
removes duplicate -g for geometryPath / geometry mode in CLI and moves to Geometry only
adds DisableAnalytics to unify tests that use CLI.
adds DynamoCoreTests,TestServices,DSOffice and FFITarget .csprojs to the DynamoCoreNet6.sln.
unifies on a new version of Moq which can be referenced from NET6 -
- ⚠️ this brings in new dependencies to the bin folder - ~~I have tried to filter them out during the install.sln so they are not delivered~~ These are now copied to the test/test_dependencies folder and resolvers added to look here during testing.
- Existing issue - I have noticed that some test binaries are already being included since at least 2.8 - thats as far back as I went - (FFITarget,Moq, Nunit.Framework) - it appears that exclusions need to be added to the robo copy step in dynamoinstall.csproj - hopefully we come up with a more holistic solution before the next GL. https://jira.autodesk.com/browse/DYN-5673
- updates use of moq to apis in new version.
make DSOffice.csproj conditional so it does not reference or build exel interop nodes for net6 (open xml is built)
conditionally updates DynamoCoreTests.csproj to Nunit3 for NET6
- ⚠️ - serialization tests fail when comparing dictionaries now - I've created a test only comparison func that seems to work using sequence equals on keys and vals - only for DynamoDictionaries.
- use #ifdefs to move to new NUnit3 asserts and attributes.
- marks some tests as Category("FailureNET6")] - some of these can be fixed with more complex refactoring so we can file a followup.
DynamoCoreTests had some transitive WPF references - attempted to refactor the easy ones by moving tests to DynamoCoreWFPtests.csproj.
AssemblyResolve behavior has changed between .net48 and .net6 - runtime better handles resolvers that throw exceptions. (this required test changes)
unify on Microsoft.NET.Test.Sdk 17 between both solutions.
skip a few migration tests that check excel and legacy unit nodes when targeting .net6.
Moves PythonMigration tests to DynamoPythonTest project
TypeForwards TestExtensions from SystemTestServices to TestServices so it can be used in DynamoCoreTests without transitive WPF dep.

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated

Release Notes

Support Net6 target for DynamoCoreTests.dll

Reviewers

build portable pdbs

update nuspec

unclear if tests pass

src/DynamoCore.net6.sln

add back ms test sdk - its needed in bin folder.

…ot precise enough.

test/DynamoCoreTests/NodeMigrationTests.cs

test/DynamoCoreTests/UnitsOfMeasureTests.cs

aparajit-pratap · 2023-03-02T22:52:42Z

test/DynamoCoreTests/SerializationTests.cs

                    // fails.
-                    Assert.AreEqual(valueA, valueB,
+
+                    Assert.That(valueA, Is.EqualTo(valueB).Using<Dictionary>(DynamoDictionaryEquality),


mark test failure

…0tests

pinzart90 · 2023-03-06T14:51:38Z

src/VisualizationTests/WpfVisualizationTests.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">


how are we running tests for a wpf project ?
Or what is this change about ?
I see there is also a new Setup.cs file ? why ?

because now Moq (v 4.18 - even on net48) has new dependencies which I only copy to the test/test_dependencies folder. So we need to setup a setupfixture resolve handler to find them.

It just seemed to me that most of the Visualization tests are derived from SystemTestBase which already uses an AssemblyResolver which we could use

yes, but not all of them - then we'd have two places to remember to look for this resolve to occur.

test/DynamoCoreTests/DynamoCoreTests.csproj

pinzart90 · 2023-03-06T15:06:11Z

test/DynamoCoreTests/DynamoCoreTests.csproj

+    <Copy SourceFiles="$(PkgSystem_Buffers)\lib\netstandard2.0\System.Buffers.dll" DestinationFolder="$(TestDependenciesPath)" />
+</Target>
+
+  <Target Name="MoveSomeTestDepsOutOfBin_net48" AfterTargets="Build" Condition=" '$(TargetFramework)' == 'net48' ">


so we are moving stuff out even on net48 ? That will not break Revit installers ?

no because these are new dependencies of Moq - and I put Moq back in the bin folder as the last step:

<Copy SourceFiles="$(PkgMoq)\lib\netstandard2.0\Moq.dll" DestinationFolder="$(OutputPath)" />

pinzart90 · 2023-03-06T15:08:13Z

test/Libraries/PackageManagerTests/Setup.cs

@@ -0,0 +1,43 @@
+using Dynamo.Utilities;


why is a new Setup.cs needed ?

same reason as above, this assembly uses moq.

pinzart90

A couple of questions, then LGTM

mjkkirschner · 2023-03-06T21:44:08Z

the test failure appears to have come from here:
#13794
merging.

…oDS#13766) * add new action * try general var syntax * update * dont use regen in core * try also not generating resource binaries for string resources * pull actual code changes * linux paths * test command * add single test project to sln * add new nuspec * add post script * revert adding test proj build portable pdbs * build portable in release update nuspec * remove publish script * remove test from github action * review comments * by hook or by crook we'll reuse existing test base classes. * this works * both solutions build at this point unclear if tests pass * try running some linux tests * build current branch from fork * updates * updates * update * ugh fix bug * fix test * fix more tests * fix more tests * fix mono build * try cat = unittests * linux not finding any tests * Update dynamoNet6.0_linux_build.yml * dont run tests * dont include castle core in build upgrade moq * remove net60smoketests unify on 17 version of ms.net.test.sdk * update python and fix refs * remove duplicate ms.net.test.sdk ref * introduce junit logger add back ms test sdk - its needed in bin folder. * use custom dictionary comparison function in nunit * compare keys and values when encountering dictionary - toString was not precise enough. * fix test mark test failure * introduce a failure * update dscpython with split * fix build for nunit2 * remove failure * copy moqs deps to test deps directory * fix * find moq for tests that were failing * review comments * review comments * mark failure

* add new action * try general var syntax * update * dont use regen in core * try also not generating resource binaries for string resources * pull actual code changes * linux paths * test command * add single test project to sln * add new nuspec * add post script * revert adding test proj build portable pdbs * build portable in release update nuspec * remove publish script * remove test from github action * review comments * by hook or by crook we'll reuse existing test base classes. * this works * both solutions build at this point unclear if tests pass * try running some linux tests * build current branch from fork * updates * updates * update * ugh fix bug * fix test * fix more tests * fix more tests * fix mono build * try cat = unittests * linux not finding any tests * Update dynamoNet6.0_linux_build.yml * dont run tests * dont include castle core in build upgrade moq * remove net60smoketests unify on 17 version of ms.net.test.sdk * update python and fix refs * remove duplicate ms.net.test.sdk ref * introduce junit logger add back ms test sdk - its needed in bin folder. * use custom dictionary comparison function in nunit * compare keys and values when encountering dictionary - toString was not precise enough. * fix test mark test failure * introduce a failure * update dscpython with split * fix build for nunit2 * remove failure * copy moqs deps to test deps directory * fix * find moq for tests that were failing * review comments * review comments * mark failure

mjkkirschner added 30 commits February 8, 2023 16:28

add new action

4daf4dd

try general var syntax

fcc572e

update

de39a63

dont use regen in core

802367b

try also not generating resource binaries for string resources

2258630

pull actual code changes

7377cdb

linux paths

7e66e50

test command

4ee22ff

add single test project to sln

e1a5e7e

add new nuspec

22435c3

add post script

24ffb90

revert adding test proj

d1b5e73

build portable pdbs

build portable in release

a2df0ca

update nuspec

remove publish script

cc08b3a

remove test from github action

d7e1abf

review comments

46ec462

by hook or by crook we'll reuse existing test base classes.

2f0a375

this works

8f6ed83

both solutions build at this point

abb1490

unclear if tests pass

try running some linux tests

48ee12e

build current branch from fork

c296bbf

updates

e919593

updates

352ee50

update

53dc2d5

ugh fix bug

05c43a3

fix test

2543b1c

fix more tests

a95f53e

fix more tests

e04d5e2

Merge branch 'master' into net60tests

40c24b6

fix mono build

b8a6f62

remove duplicate ms.net.test.sdk ref

bceedca

aparajit-pratap reviewed Mar 2, 2023

View reviewed changes

src/DynamoCore.net6.sln Show resolved Hide resolved

mjkkirschner added 3 commits March 2, 2023 14:18

introduce junit logger

d2a5e47

add back ms test sdk - its needed in bin folder.

use custom dictionary comparison function in nunit

9d8c90c

compare keys and values when encountering dictionary - toString was n…

ac55692

…ot precise enough.

aparajit-pratap reviewed Mar 2, 2023

View reviewed changes

aparajit-pratap approved these changes Mar 2, 2023

View reviewed changes

mjkkirschner added 10 commits March 2, 2023 17:58

fix test

1e0d11b

mark test failure

introduce a failure

8bd66fc

Merge branch 'master' of https://github.com/DynamoDS/Dynamo into net6…

67fe4c3

…0tests

update dscpython with split

4243d4a

fix build for nunit2

a842eb1

remove failure

dc882b3

copy moqs deps to test deps directory

2f8ecfd

fix

aaf1061

find moq for tests that were failing

3fbbac0

review comments

25e1919

pinzart90 reviewed Mar 6, 2023

View reviewed changes

test/DynamoCoreTests/DynamoCoreTests.csproj Outdated Show resolved Hide resolved

pinzart90 reviewed Mar 6, 2023

View reviewed changes

test/DynamoCoreTests/DynamoCoreTests.csproj Outdated Show resolved Hide resolved

pinzart90 reviewed Mar 6, 2023

View reviewed changes

pinzart90 approved these changes Mar 6, 2023

View reviewed changes

mjkkirschner added 2 commits March 6, 2023 11:24

review comments

77207e1

mark failure

767ac54

mjkkirschner merged commit 1088c1e into DynamoDS:master Mar 6, 2023

mjkkirschner deleted the net60tests branch March 6, 2023 21:44

		@@ -1,4 +1,4 @@
		<Project Sdk="Microsoft.NET.Sdk">
		<Project Sdk="Microsoft.NET.Sdk">

Conversation

mjkkirschner commented Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Declarations

Release Notes

Reviewers

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjkkirschner Mar 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pinzart90 left a comment

Choose a reason for hiding this comment

Uh oh!

mjkkirschner commented Mar 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mjkkirschner commented Feb 21, 2023 •

edited

Loading

mjkkirschner Mar 6, 2023 •

edited

Loading