DYN-4964-Popup-GeometryScaling Several Fixes#13734
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Feb 13, 2023
RobertGlobant20:DYN-4964-Popup-GeometryScaling-CodeReviewBugs
Merged
DYN-4964-Popup-GeometryScaling Several Fixes#13734QilongTang merged 2 commits intoDynamoDS:masterfrom RobertGlobant20:DYN-4964-Popup-GeometryScaling-CodeReviewBugs
QilongTang merged 2 commits intoDynamoDS:masterfrom
RobertGlobant20:DYN-4964-Popup-GeometryScaling-CodeReviewBugs
Conversation
Based in the changes suggested in the next pull request: #13727 I did the next changes: - Remove the property DefaultScaleFactor from IPreferences. - Add braces in some places. - Modify the SetDefaultScaleFactor method for passing one parameter. - Modify the ScaleRange property to use named tuples. - Add comments to public properties.
7 tasks
Fixing bug reported by Aabi about that the button is showing blank when is pressed, then I added the image to be shown when the button is pressed.
Contributor
Author
|
@avidit the bug related to the button disappearing when is pressed should be fixed with the next commit (once this PR is merged to master). |
QilongTang
approved these changes
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Based in the changes suggested in the next pull request: #13727 I did the next changes:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Several changes based in the next pull request: #13727
Reviewers
@mjkkirschner @zeusongit
FYIs