DYN-4308 Input and output port menu Y location#13683
Merged
reddyashish merged 2 commits intoDynamoDS:masterfrom Jan 20, 2023
Merged
DYN-4308 Input and output port menu Y location#13683reddyashish merged 2 commits intoDynamoDS:masterfrom
reddyashish merged 2 commits intoDynamoDS:masterfrom
Conversation
…igger when zoomed out - redo of the Y position calculation
reddyashish
reviewed
Jan 19, 2023
reddyashish
approved these changes
Jan 19, 2023
Collaborator
reddyashish
left a comment
There was a problem hiding this comment.
LGTM with one comment
Collaborator
|
The failing test here WorkspaceContextMenu_TestIfSearchTextClearsOnOpeningContextMenu is flaky. |
- a small fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The PR solves an outstanding issue DYN-4308 'Input and output port menu is tiny when zoomed in and gets bigger when zoomed out'. The way the Y value of the popup context menu position was calculated did not take into account a few factors, which reflected in inaccurate position in different scale factors in relationship to the corresponding port.
Location after the solution
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
FYIs
@Amoursol
@Jingyi-Wen