DYN-4734 Contrast ratio between a group background and group text fix#13682
Merged
reddyashish merged 1 commit intoDynamoDS:masterfrom Jan 20, 2023
Merged
Conversation
- now measures the current group text to group background contrast ratio and adjusts text color according to the group background color, so good contrast is maintained
Contributor
|
@dnenov looks awesome! Could we do one quick test with a 50% contrast color around the middle (As in close to when it switches between white and black) to check legibility? |
Collaborator
Author
Sure thing, I uploaded a test case in the body of the PR, I hope that's helpful. |
reddyashish
approved these changes
Jan 20, 2023
Mikhinja
reviewed
Aug 28, 2024
| var lightColor = (System.Windows.Media.Color)SharedDictionaryManager.DynamoColorsAndBrushesDictionary["WhiteColor"]; | ||
| var darkColor = (System.Windows.Media.Color)SharedDictionaryManager.DynamoColorsAndBrushesDictionary["DarkerGrey"]; | ||
|
|
||
| var backgroundColor = (System.Windows.Media.Color)value; |
Contributor
There was a problem hiding this comment.
Not sure if the foreground color ( value ) can ever be null, but it won't hurt to do a check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses DYN-4734 'As a Dynamo user, I want clear contrast between group background and group text'. The requirements are:
Contrast ratio test
Using this tool to measure the contrast between the #3C3C3C text color and chosen background color.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
FYIs
@Amoursol
@Jingyi-Wen