Skip to content

Don't throw if a package has dlls but no node libraries in a protected location#13625

Merged
sm6srw merged 1 commit intoDynamoDS:masterfrom
sm6srw:Package_Load_Fix
Dec 9, 2022
Merged

Don't throw if a package has dlls but no node libraries in a protected location#13625
sm6srw merged 1 commit intoDynamoDS:masterfrom
sm6srw:Package_Load_Fix

Conversation

@sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Dec 9, 2022

Purpose

This pull request does:

  • Log instead of throw if a package has dlls but no node libraries in a protected location

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Fixes an issue where a notification is shown if a package has no node libraries in a protected location

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@sm6srw sm6srw requested a review from QilongTang December 9, 2022 21:01
Copy link
Member

@mjkkirschner mjkkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the tests pass

@sm6srw
Copy link
Contributor Author

sm6srw commented Dec 9, 2022

@sm6srw sm6srw merged commit f1452d6 into DynamoDS:master Dec 9, 2022
@sm6srw sm6srw deleted the Package_Load_Fix branch December 9, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants