Skip to content

Cherry picks#13613

Merged
QilongTang merged 3 commits intoRC2.17.0_masterfrom
Cherry-Picks
Dec 7, 2022
Merged

Cherry picks#13613
QilongTang merged 3 commits intoRC2.17.0_masterfrom
Cherry-Picks

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Dec 7, 2022

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Cherry-picking #13607 #13612 #13602

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

N/A

Reviewers

FYIs

@DynamoDS/dynamo

QilongTang and others added 3 commits December 7, 2022 12:13
@QilongTang
Include all files from Markdown Directory to published package (#13607)
0a632ac 
* update

* add all files under Markdown Dir to pkg

* update comment

* update tests

* update test

* update tests

* update comments

* update test
@filipeotero @QilongTang
Adding localization for the sign in button states (#13612)
b73c21e
@RobertGlobant20 @QilongTang
DYN-5322 Update ML NodeAutocomplete Documentation (#13602)
6f990e2 
* DYN-5322-Doc-MLNodeAutocomplete

I updated the NodeAutocompleteDcoumentation.html to match the docx document attached to the Jira task.
For the GIFs/PNG updated I did the next actions:
- Modified the original images resolution to 450 x XXX (according to the aspect ratio).
- Compressed the modified image/GIF so it will use the minimum size in the html file when converted to Base 64 (otherwise the WebView2 component was crashing).
- Convert the Image/GIF to Base64 content and put it in the HTML file.

* DYN-5322-Doc-MLNodeAutocomplete CodeReview1

I've added the MouseDown event and the handler so every time the question mark symbol is clicked in the preferences panel the DocumentationBrowser ML NodeAutocomplete documentation will be opened.
@QilongTang QilongTang merged commit 5584c1a into RC2.17.0_master Dec 7, 2022
@QilongTang QilongTang deleted the Cherry-Picks branch December 7, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QilongTang @filipeotero @RobertGlobant20