DYN-5423 Fix CustomNode view layout after it is saved.#13585
Merged
reddyashish merged 3 commits intoDynamoDS:masterfrom Nov 30, 2022
Merged
DYN-5423 Fix CustomNode view layout after it is saved.#13585reddyashish merged 3 commits intoDynamoDS:masterfrom
reddyashish merged 3 commits intoDynamoDS:masterfrom
Conversation
Contributor
|
Excellent! Do you know when this regression begin to happen? |
reddyashish
commented
Nov 30, 2022
Collaborator
Author
|
@QilongTang After this #12687 fix by me, which was to store and retrieve the custom node file-path info after it is saved without the need to restart Dynamo. |
Contributor
Gotcha, looks like this has been failing for a while. Would you add a unit test to guard it? |
QilongTang
reviewed
Nov 30, 2022
QilongTang
reviewed
Nov 30, 2022
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with one question
QilongTang
approved these changes
Nov 30, 2022
QilongTang
pushed a commit
that referenced
this pull request
Dec 1, 2022
* Fix CustomNode views after it is saved. * Add test * Update WorkspaceSaving.cs
QilongTang
added a commit
that referenced
this pull request
Dec 1, 2022
* Fix CustomNode view layout after it is saved. (#13585) * Fix CustomNode views after it is saved. * Add test * Update WorkspaceSaving.cs * Single quote to double quote in js call functions (#13586) * DYN-5286-MLNodeAutocomplete Adding Analytics (#13581) * DYN-5286-MLNodeAutocomplete-Analytics I added the code for TrackEvent in 4 places: - NodeAutoCompleteSearchControl.xaml.cs - when clicking the Low Confidence combobox for displaying the list of nodes. - NodeAutoCompleteSearchViewModel.cs - when the Node Autocomplete is raised using the Recommented nodes option or the Object Types option. - PreferencesView.xaml.cs when the Slider Confidence Level is updated. And finally I've added additional Actions in IAnalyticsClient.cs * DYN-5286-MLNodeAutocomplete-Analytics CodeReview1 Removed the Actions added in IAnalyticsClient.cs so we can re-use the existing ones (so the method calls were also updated). Added Analytics track events in the Preferences panel when the NodeAutocomplete is se to ML Recomentations or Object Type. The ExportSettings option and ImportSettings option were renamed to Export and Import (so the method calls were also updated). * Update * update * Update Co-authored-by: Aaron (Qilong) <[email protected]> * DYN-5426 Setting different font size when the height of the library is smaller (#13578) * Setting different font size when the height is smaller * calculate the font size based on the screen height Co-authored-by: reddyashish <[email protected]> Co-authored-by: filipeotero <[email protected]> Co-authored-by: Roberto T <[email protected]>
8 tasks
QilongTang
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Fix CustomNode views after it is saved. * Add test * Update WorkspaceSaving.cs
9 tasks
QilongTang
added a commit
that referenced
this pull request
Jul 13, 2023
* Fix CustomNode views after it is saved. * Add test * Update WorkspaceSaving.cs Co-authored-by: reddyashish <[email protected]>
QilongTang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Task: https://jira.autodesk.com/browse/DYN-5423.
This PR is to fix the custom node layout by serializing the "Views" property when a new file is saved. This is done in the WorkspaceViewModel which will handle both the HomeWorkspaceModel and CustomNodeWorkspaceModel.
The previous check for CustomNodeWorkspaceModel is moved inside WorkspaceViewModel, where we will update the file path info in the custom node manager after a new custom node file is saved (related to the PR).
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fix CustomNode view layout after it is saved.
Reviewers
@DynamoDS/dynamo