DYN-5286-MLNodeAutocomplete Adding Analytics #13581
Merged
QilongTang merged 5 commits intoDynamoDS:masterfrom Dec 1, 2022
RobertGlobant20:DYN-5286-MLNodeAutocomplete-Analytics
Merged
DYN-5286-MLNodeAutocomplete Adding Analytics #13581QilongTang merged 5 commits intoDynamoDS:masterfrom RobertGlobant20:DYN-5286-MLNodeAutocomplete-Analytics
QilongTang merged 5 commits intoDynamoDS:masterfrom
RobertGlobant20:DYN-5286-MLNodeAutocomplete-Analytics
Conversation
I added the code for TrackEvent in 4 places: - NodeAutoCompleteSearchControl.xaml.cs - when clicking the Low Confidence combobox for displaying the list of nodes. - NodeAutoCompleteSearchViewModel.cs - when the Node Autocomplete is raised using the Recommented nodes option or the Object Types option. - PreferencesView.xaml.cs when the Slider Confidence Level is updated. And finally I've added additional Actions in IAnalyticsClient.cs
QilongTang
reviewed
Nov 30, 2022
reddyashish
reviewed
Nov 30, 2022
Collaborator
reddyashish
left a comment
reddyashish
left a comment
There was a problem hiding this comment.
LGTM once the test is added.
QilongTang
reviewed
Nov 30, 2022
QilongTang
reviewed
Nov 30, 2022
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Nov 30, 2022
QilongTang
reviewed
Nov 30, 2022
QilongTang
reviewed
Nov 30, 2022
Contributor
Author
@reddyashish I got confused, do I need to add a test? |
Removed the Actions added in IAnalyticsClient.cs so we can re-use the existing ones (so the method calls were also updated). Added Analytics track events in the Preferences panel when the NodeAutocomplete is se to ML Recomentations or Object Type. The ExportSettings option and ImportSettings option were renamed to Export and Import (so the method calls were also updated).
QilongTang
reviewed
Dec 1, 2022
| Analytics.TrackEvent( | ||
| Actions.Show, | ||
| Categories.NodeAutoCompleteOperations, | ||
| nameof(NodeAutocompleteSuggestion.ObjectType)); |
Contributor
There was a problem hiding this comment.
My mistake, I thought this is the code flip the mode but this is the actual display code. Updated and I will add tracking where user can flip mode within node autocomplete UI
QilongTang
approved these changes
Dec 1, 2022
Contributor
|
Added tracking for case where we display no recommendation or could not fetch results. LGTM. @RobertGlobant20 Please update the corresponding PR in Analytics.Net repo. |
QilongTang
added a commit
that referenced
this pull request
Dec 1, 2022
* DYN-5286-MLNodeAutocomplete-Analytics I added the code for TrackEvent in 4 places: - NodeAutoCompleteSearchControl.xaml.cs - when clicking the Low Confidence combobox for displaying the list of nodes. - NodeAutoCompleteSearchViewModel.cs - when the Node Autocomplete is raised using the Recommented nodes option or the Object Types option. - PreferencesView.xaml.cs when the Slider Confidence Level is updated. And finally I've added additional Actions in IAnalyticsClient.cs * DYN-5286-MLNodeAutocomplete-Analytics CodeReview1 Removed the Actions added in IAnalyticsClient.cs so we can re-use the existing ones (so the method calls were also updated). Added Analytics track events in the Preferences panel when the NodeAutocomplete is se to ML Recomentations or Object Type. The ExportSettings option and ImportSettings option were renamed to Export and Import (so the method calls were also updated). * Update * update * Update Co-authored-by: Aaron (Qilong) <[email protected]>
QilongTang
added a commit
that referenced
this pull request
Dec 1, 2022
* Fix CustomNode view layout after it is saved. (#13585) * Fix CustomNode views after it is saved. * Add test * Update WorkspaceSaving.cs * Single quote to double quote in js call functions (#13586) * DYN-5286-MLNodeAutocomplete Adding Analytics (#13581) * DYN-5286-MLNodeAutocomplete-Analytics I added the code for TrackEvent in 4 places: - NodeAutoCompleteSearchControl.xaml.cs - when clicking the Low Confidence combobox for displaying the list of nodes. - NodeAutoCompleteSearchViewModel.cs - when the Node Autocomplete is raised using the Recommented nodes option or the Object Types option. - PreferencesView.xaml.cs when the Slider Confidence Level is updated. And finally I've added additional Actions in IAnalyticsClient.cs * DYN-5286-MLNodeAutocomplete-Analytics CodeReview1 Removed the Actions added in IAnalyticsClient.cs so we can re-use the existing ones (so the method calls were also updated). Added Analytics track events in the Preferences panel when the NodeAutocomplete is se to ML Recomentations or Object Type. The ExportSettings option and ImportSettings option were renamed to Export and Import (so the method calls were also updated). * Update * update * Update Co-authored-by: Aaron (Qilong) <[email protected]> * DYN-5426 Setting different font size when the height of the library is smaller (#13578) * Setting different font size when the height is smaller * calculate the font size based on the screen height Co-authored-by: reddyashish <[email protected]> Co-authored-by: filipeotero <[email protected]> Co-authored-by: Roberto T <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adding Analytics for ML Node Autocomplete
I added the code for TrackEvent in 4 places:
(I'm still missing local test)
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Adding Analytics for ML Node Autocomplete
Reviewers
@QilongTang
FYIs
@reddyashish