Include md files from MarkdownFiles Directory field when publishing#13577
Merged
QilongTang merged 4 commits intomasterfrom Nov 30, 2022
Merged
Include md files from MarkdownFiles Directory field when publishing#13577QilongTang merged 4 commits intomasterfrom
QilongTang merged 4 commits intomasterfrom
Conversation
src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
Outdated
Show resolved
Hide resolved
Member
Contributor
Author
|
Updated, PTAL. Tested locally that unit test pass and the md files under optional dir is copied to docs folder when publishing |
mjkkirschner
approved these changes
Nov 29, 2022
Member
|
If you have time it would be good to update the package builder tests to add tests for the docs folder. |
Contributor
Author
Sure. Done |
QilongTang
added a commit
that referenced
this pull request
Nov 30, 2022
…13577) * Include Markdown files as package content * Update * Update * Add unit test
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Per https://jira.autodesk.com/browse/DYN-5447, when publishing the current package, include Markdown files from MarkdownFiles Directory field.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Include md files from MarkdownFiles Directory field when publishing
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of