Dyn 5427 confidence threshold autocomplete ml#13562
Dyn 5427 confidence threshold autocomplete ml#13562reddyashish merged 12 commits intoDynamoDS:masterfrom jesusalvino:DYN-5427-ConfidenceThreshold-AutocompleteML
Conversation
|
|
|
LGTM. The ML autocomplete request here https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs#L38 should be using these values from settings. Can you make that change as well and also resolve the conflicts. |
Done. |
|
Looks good to me with one comment. The only test failing is the IfSubmenuOpenOnMouseHover which is flaky. |
that test works for me locally |
|
Yes that test was failing intermittently on master-5. We can ignore that. |
|
The last job has this failing test [Dynamo.Tests.Configuration.PreferenceSettingsTests.TestImportCopySettings] |
Done. |
|
Thanks @jesusalvino. We can merge this after the job gets finished. Once @QilongTang confirms if this can still get in for 2.17, we can cherry-pick it. |
* Hide Nodes * Update UI with Expander * Node Autocomplete Section Done * Set default number of results as 10 * restoring version * restoring entire file * Connect the confidence level and nuber of result settings * Fix * Labels * Naming changes * Updating the Settings properties for copy test
4 participants
Purpose
Implementation of the story https://jira.autodesk.com/browse/DYN-5427
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@RobertGlobant20 @filipeotero