DYN-4224 / DYN-4225 Watch3d Updates (Persistent camera and node size …#13534
Merged
QilongTang merged 1 commit intoRC2.17.0_masterfrom Nov 17, 2022
Merged
DYN-4224 / DYN-4225 Watch3d Updates (Persistent camera and node size …#13534QilongTang merged 1 commit intoRC2.17.0_masterfrom
QilongTang merged 1 commit intoRC2.17.0_masterfrom
Conversation
…between saves / Ignore Node preview state) (#12150) * Use exisitng width, height, and camera during deserialization * Allow Watch3D to tessellate directly connected nodes independent of preview state * One more change for directly connected * Fix bug with port connection and disconnect events * pr comments * Ignore certain cases * PR comments * update comments * Update DefaultWatch3DViewModel.cs * Added deserialization test for HelixWatch3D node * Added the dyn file for the HelixWatch3D node deserialization test * Added testing for Width deserialization * Renamed test dyn file * Added test for ignoring IsVisible parameter by Watch3d node * Fixed wrong test geometry in dyn file * Added another Assert to the IgnoreIsVisible test * Fixed Assert statements * Simplified a test * Remove node_modules. * Fix test. * Simplify Co-authored-by: Craig Long <[email protected]> Co-authored-by: Long Nguyen <[email protected]> Co-authored-by: Trygve Wastvedt <[email protected]> (cherry picked from commit 903ca10)
QilongTang
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picks #12150 to 2.17.