Leave RenderPackage data intact when passed to AggregateRenderPackage…#13519
Merged
QilongTang merged 1 commit intoRC2.17.0_masterfrom Nov 16, 2022
Merged
Leave RenderPackage data intact when passed to AggregateRenderPackage…#13519QilongTang merged 1 commit intoRC2.17.0_masterfrom
QilongTang merged 1 commit intoRC2.17.0_masterfrom
Conversation
#13437) * Leave RP data intact * Fix tests * Remove unnessary code * Spelling typos and clean up * clean up * clean up * Add regression test for render package mutation. * Unsubscribe from event. * Add image comparison test for render bug. * Fix test image size. Co-authored-by: Craig Long <[email protected]> Co-authored-by: Trygve Wastvedt <[email protected]> (cherry picked from commit 104ac05)
mjkkirschner
approved these changes
Nov 15, 2022
Contributor
Author
|
@mjkkirschner Looks like the |
Contributor
That is sporadic, please ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick from #13437 into 2.17.