Integrating ML node autocomplete. #13496
Merged
reddyashish merged 22 commits intoDynamoDS:masterfrom Nov 17, 2022
Merged
Conversation
Contributor
|
@reddyashish Do we get confidence as part of the response? Since from the gif, it is not there yet, just curious |
zeusongit
reviewed
Nov 10, 2022
zeusongit
reviewed
Nov 10, 2022
zeusongit
reviewed
Nov 10, 2022
Collaborator
Author
|
@QilongTang Yes we do get the confidence score, I am adding a field to show that. Will push those changes. |
varvaratou
reviewed
Nov 10, 2022
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
reddyashish
commented
Nov 11, 2022
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
reddyashish
commented
Nov 15, 2022
reddyashish
commented
Nov 15, 2022
reddyashish
commented
Nov 15, 2022
QilongTang
approved these changes
Nov 15, 2022
Contributor
|
@reddyashish The job reported failed but I dont see any regressions? Can you double check |
Collaborator
Author
|
Failed while getting the package: Error downloading 'adp-desktop-sdk_win_release_intel64_v140.4.2.0' |
Collaborator
Author
|
Job passed. Merging this. |
reddyashish
added a commit
to reddyashish/Dynamo
that referenced
this pull request
Nov 17, 2022
* Integrate ML Node-Autocompletion, * Update NodeModel.cs * Update NodeModel.cs * some changes * more changes * Update NodeAutoCompleteSearchControl.xaml * Fix edge cases and UI improvements. * update * Update NodeAutoCompleteSearchControl.xaml * fix highlighting items. * fix * Port name for variable input nodes. * Add base test. * addressing comments. * Fix the edge cases for search results. * Clean up code * Update NodeAutoCompleteSearchViewModel.cs * refactoring. * updates * Use IDSDK token for authentication * updates (cherry picked from commit 34fe0f1)
8 tasks
reddyashish
added a commit
that referenced
this pull request
Nov 17, 2022
* Integrate ML Node-Autocompletion, * Update NodeModel.cs * Update NodeModel.cs * some changes * more changes * Update NodeAutoCompleteSearchControl.xaml * Fix edge cases and UI improvements. * update * Update NodeAutoCompleteSearchControl.xaml * fix highlighting items. * fix * Port name for variable input nodes. * Add base test. * addressing comments. * Fix the edge cases for search results. * Clean up code * Update NodeAutoCompleteSearchViewModel.cs * refactoring. * updates * Use IDSDK token for authentication * updates (cherry picked from commit 34fe0f1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Integrating ML node autocomplete.
Task: https://jira.autodesk.com/browse/DYN-5335
API Schema info: https://wiki.autodesk.com/pages/viewpage.actionspaceKey=~misolm&title=Dynamo+Node+Autocomplete+-+Schema
To-do changes
a) Background is not transparent - fixed
b) Hover state on item should be consistent with hover state in library - fixed
c) Search bar - matching the figma link - fixed
d) Switch method icon rotate 90% degrees, hover blue should be the icon itself instead of the background - fixed
e) Scrolling of the nodes in autocompletion window has regressed - fixed
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Integrating ML node autocomplete.
Reviewers
@QilongTang @zeusongit
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of