Dyn 4837 group styles default font size#13447
Merged
QilongTang merged 15 commits intoDynamoDS:masterfrom Nov 2, 2022
jesusalvino:DYN-4837-GroupStyles-Default-Font-Size
Merged
Dyn 4837 group styles default font size#13447QilongTang merged 15 commits intoDynamoDS:masterfrom jesusalvino:DYN-4837-GroupStyles-Default-Font-Size
QilongTang merged 15 commits intoDynamoDS:masterfrom
jesusalvino:DYN-4837-GroupStyles-Default-Font-Size
Conversation
Contributor
Author
|
|
Contributor
|
Changes looks good but default font size should be 36 instead of 14? Currently, when creating group, the default font size is 36 |
QilongTang
approved these changes
Oct 31, 2022
QilongTang
reviewed
Oct 31, 2022
reddyashish
reviewed
Oct 31, 2022
reddyashish
approved these changes
Oct 31, 2022
Contributor
|
Can you add what preferences setting would looks like now and also please add/update unit tests |
Contributor
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Implemente the improvement https://jira.autodesk.com/browse/DYN-4837
(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@RobertGlobant20 @filipeotero