Add authentication feature to Dynamo Sandbox#13445
Merged
QilongTang merged 7 commits intoDynamoDS:masterfrom Nov 1, 2022
Merged
Add authentication feature to Dynamo Sandbox#13445QilongTang merged 7 commits intoDynamoDS:masterfrom
QilongTang merged 7 commits intoDynamoDS:masterfrom
Conversation
QilongTang
reviewed
Oct 31, 2022
QilongTang
reviewed
Oct 31, 2022
QilongTang
reviewed
Oct 31, 2022
| <None Remove="Views\GuidedTour\HtmlPages\Resources\ConnectTheNode.gif" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="Autodesk.IDSDK" Version="1.1.5" /> |
Contributor
There was a problem hiding this comment.
Can you remind me why do we need the dependency here as well as DynamoCore?
Contributor
Author
There was a problem hiding this comment.
we don't need it here, I can remove this
Contributor
There was a problem hiding this comment.
@zeusongit Autodesk.IDSDK is library private not public to open sources ?
Contributor
Author
There was a problem hiding this comment.
yes, it is private for now.
QilongTang
reviewed
Oct 31, 2022
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
A few comments but good progress
Contributor
|
Would you clean up this PR and make it ready for review? Would love to get it in today without the login function |
QilongTang
changed the title
QilongTang
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-5186
This PR enable Dynamo Sandbox users to authenticate and login themselves using their Autodesk credentials. This will enable them to access Package Manager publish feature as well other upcoming features that will require authentication.
The environment and client ID required are provided by the config file.
Note: We are still waiting for some approvals and nuget package deployment in order for this to work [Do not merge].
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/dynamo