Update node descriptions in Core Node Models library#13424
Merged
QilongTang merged 4 commits intomasterfrom Oct 26, 2022
Merged
Update node descriptions in Core Node Models library#13424QilongTang merged 4 commits intomasterfrom
QilongTang merged 4 commits intomasterfrom
Conversation
hwahlstrom
added
DNM
QilongTang
approved these changes
Oct 24, 2022
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM but usually the designer files are updated as well. Did you edit using a regular editor instead of visual studio? But I think the file will be updated build time..
hwahlstrom
changed the title
Contributor
|
Two regressions found, must be some tests depending on validation of node descriptions: Working on the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Updating Core Node Models library node descriptions to adhere to node description content pattern.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Updated descriptions for several nodes in the Core Node Models library to improve clarity and consistency.
Reviewers
@Amoursol
FYIs