Fix dropdown input nodes when running from player with Dynamo open#13403
Merged
QilongTang merged 4 commits intomasterfrom Nov 9, 2022
Merged
Fix dropdown input nodes when running from player with Dynamo open#13403QilongTang merged 4 commits intomasterfrom
QilongTang merged 4 commits intomasterfrom
Conversation
QilongTang
reviewed
Nov 8, 2022
QilongTang
reviewed
Nov 8, 2022
QilongTang
reviewed
Nov 8, 2022
QilongTang
approved these changes
Nov 8, 2022
Contributor
QilongTang
left a comment
There was a problem hiding this comment.
One comment then LGTM
Contributor
|
Waiting for all PR checks to finish |
Contributor
|
Reported regression is a glitch |
Contributor
|
@twastvedt I assume the actual testing will be done by Vera team on this |
Contributor
Author
|
@QilongTang Yes we will! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes AGD-2777
When running a graph from Dynamo Player while the Dynamo UI was open, the value and UI display of dropdown nodes was not updated consistently.
DropDown.UpdateValueCoreuses theSelectedIndexsetter instead of its own logic.DropDown.SelectedIndexsetter runsRaisePropertyChanged("SelectedString"). (Previously it changedselectedStringbut did not alert the UI of the change.)Opportunistic fixes:
DropDown.SelectedStringsetter runsRaisePropertyChanged("SelectedIndex"). (Previously it changedselectedIndexbut did not alert the UI of the change.)DropDown.SelectedStringsetter does nothing if the given value is the same as the current value.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@saintentropy