DYN-5268 integrate web splash screen to Sandbox#13395
DYN-5268 integrate web splash screen to Sandbox#13395QilongTang merged 28 commits intoDynamoDS:masterfrom
Conversation
src/DynamoSandbox/DynamoCoreSetup.cs
Outdated
| migrationWindow.webView.NavigationCompleted += WebView_NavigationCompleted; | ||
| migrationWindow.RequestLaunchDynamo = LaunchDynamo; | ||
| migrationWindow.RequestImportSettings = ImportSettings; | ||
| migrationWindow.Show(); |
There was a problem hiding this comment.
@filipeotero @reddyashish @zeusongit @RobertGlobant20 I notice that we may not have time to adjust this before @filipeotero 's vacation, but I think we need to rename this view and move it back to DynamoCoreWpf project instead of maintaining it as part of Sandbox project. The reason I kept wondering is in order to have the splash screen to appear in DynamoRevit context, because I think the sandbox code is not called during in-process integration case
| $"welcomeToDynamoTitle: '{Properties.Resources.SplashScreenWelcomeToDynamo}'," + | ||
| $"signInTitle: '{Properties.Resources.SplashScreenSignIn}'," + | ||
| $"launchTitle: '{Properties.Resources.SplashScreenLaunchTitle}'," + | ||
| $"showScreenAgainLabel: '{Properties.Resources.SplashScreenShowScreenAgainLabel}'" + "})"); |
| } | ||
| } | ||
|
|
||
| private void LoadDynamoView() |
There was a problem hiding this comment.
This is great but I anticipate us moving this code to DynamoCoreWpf so that this can be shared between sandbox and integrations.. I would like to discuss with you tomorrow about it
QilongTang
changed the title
QilongTang
changed the title
|
@reddyashish @zeusongit @RobertGlobant20 @Amoursol I think I worked on this PR enough so that this is ready to merge so we can test splash screen tomorrow. There is one follow up step which I did not have time to do - to move the splash screen to Dynamo View for integrations which I can do after our bug bash tomorrow. I would like to hear your comments on this, although I would like to merge tonight for our daily build tomorrow, but comments will be addressed later in another PR |
4 participants
Purpose
This PR contains the implementation of the splash screen
TODO
Declarations
Check these if you believe they are true
*.resxfilesFYIs
@RobertGlobant20 @jesusalvino @QilongTang @zeusongit @reddyashish