Type identifier in preview compact bubble.#13394
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Oct 12, 2022
Merged
Conversation
Collaborator
Author
|
@QilongTang I did not need to call the type overloading methods in compact preview bubble separately, like I initially thought. Getting the type info using the Data property inside MirrorData. |
QilongTang
approved these changes
Oct 11, 2022
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
One question then LGTM
| internal const string boolType = "bool"; | ||
| internal const string intType = "int"; | ||
| internal const string objectType = "object"; | ||
| internal const string stringType = "string"; |
Contributor
There was a problem hiding this comment.
Are these defined somewhere already so we can make them static to reuse?
Collaborator
Author
There was a problem hiding this comment.
Yes, these constants were used in WatchViewModel. Removing it from WatchViewModel and CompactBubbleViewModel and using nameof property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Task: https://jira.autodesk.com/browse/DYN-5053
Add Type identifiers in preview compact bubble. Similar to preview bubble or watch node.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Type identifier in preview compact bubble.
Reviewers
@QilongTang @zeusongit