Dyn 4994 adding tests for longest/shortest replication MSIL - WIP#13343
Merged
mjkkirschner merged 20 commits intoDynamoDS:emitMSILfrom Sep 28, 2022
Merged
Dyn 4994 adding tests for longest/shortest replication MSIL - WIP#13343mjkkirschner merged 20 commits intoDynamoDS:emitMSILfrom
mjkkirschner merged 20 commits intoDynamoDS:emitMSILfrom
Conversation
* add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]>
- removed flashing white color on mouse pressed for the filter ui element
* Update Node AutoComplete Visuals * Reuse style from central location
tests pass - merging this then will send cherry pick
* Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries
DynamoDS#13338) passed here: merging.
mjkkirschner
commented
Sep 27, 2022
|
|
||
| [Test] | ||
| public void MSIL_Arithmatic_No_Replication() | ||
| public void ZTLongestLacing_ShouldReturn4Results() |
Member
Author
There was a problem hiding this comment.
these are the tests for review - note the ones marked failure :(
Contributor
There was a problem hiding this comment.
these tests should pass after @aparajit-pratap merges #13323
Contributor
|
@mjkkirschner I added case 2 of replication (exact matching) so that the tests can pass (same behavior as in the old VM) |
mjkkirschner
commented
Sep 27, 2022
| // We have a cluster of FEPs that can be used to dispatch the array | ||
| resolvedFeps = new List<CLRFunctionEndPoint>(lookups); | ||
| replicationInstructions = replicationOption; | ||
| matchFound = true; |
Contributor
There was a problem hiding this comment.
Looks like it could. But then it would be different than the old VM
mjkkirschner
commented
Sep 27, 2022
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Jan 20, 2023
…namoDS#13343) * add nunit test adapter for 2022 (DynamoDS#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (DynamoDS#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (DynamoDS#13312) * Update Node AutoComplete Dialog Visuals (DynamoDS#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (DynamoDS#13233) * Dyn5272 (DynamoDS#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (DynamoDS#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (DynamoDS#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add some lacing tests that use arb rank params * fix tests 1. Missing replication Longest/Shortest attribute 2. Fix result - wrap in list (like old VM) Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]> Co-authored-by: kirschm <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A WIP to share a few failing test cases with the team. Note the large diff with master, I will send another PR cross merging master to emitMSIL to make this PR easier to review.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of