cherry pick analytics issue by pinzart90 · Pull Request #13328 · DynamoDS/Dynamo

pinzart90 · 2022-09-21T14:49:02Z

Please Note:

Before submitting the PR, please review How to Contribute to Dynamo
Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
PRs will be reviewed from oldest to newest
If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

mjkkirschner · 2022-09-21T16:28:23Z

src/AssemblySharedInfoGenerator/AssemblySharedInfo.cs

 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyFileVersion("2.16.0.1640")]


is this branch based on 2.16 release? Is it expected the nuget version number does not match the build number - I can't recall.

The build number is based on a time dependent formula. I do not expect that to match between builds

yes, to be clear, I meant the 2.16.0.1640 was not the same as:
https://www.nuget.org/packages/DynamoVisualProgramming.ZeroTouchLibrary/2.16.0.2501
perhaps the final build that was published to nuget was not the same build that was committed to git.

In any case, I want to be clear I am talking about the old build number, not the new one.

mjkkirschner · 2022-09-21T16:29:14Z

tools/autobuild/build.json

@@ -2,8 +2,8 @@
  "product_id": "DYN",
  "release_id": "2.16.0",


release id does not change?

Yup, they dont this is how UPI works, hotfix folds under release this way (for most other ADSK products)

mjkkirschner

couple questions

aparajit-pratap · 2022-09-21T16:36:37Z

LICENSE.txt

@@ -1,4 +1,4 @@
-DYNAMO v.2.15.0 © 2022 Autodesk, Inc.  All rights reserved.
+DYNAMO v.2.16.1 © 2022 Autodesk, Inc.  All rights reserved.


I thought this was bumped up already in the 2.16 release branch 😕

I did the about box content but must have missed this file - it doesn't make it into the application so it's not an issue for users IMO.

* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]>

This reverts commit 6f9761d.

* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]>

This reverts commit 6f9761d.

* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]>

* cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>

* cherry pick analytics issue (DynamoDS#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (DynamoDS#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (DynamoDS#13328) (DynamoDS#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (DynamoDS#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (DynamoDS#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>

* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344) * fixing mem leaks in progress * fix test and remove todo * 2.19.1 disable network traffic WIP (#14393) * cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>

* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344) * fixing mem leaks in progress * fix test and remove todo * 2.19.1 disable network traffic WIP (#14393) * cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> * add python tests * move project * revert --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>

* cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <[email protected]> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <[email protected]> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]>

update

e7daefb

pinzart90 requested review from aparajit-pratap and mjkkirschner September 21, 2022 14:49

pinzart90 added 4 commits September 21, 2022 10:51

update

4de5706

null checking

3f494c8

update

9a24f1a

Update CoreNodeModelWpfResources.Designer.cs

66cb804

mjkkirschner reviewed Sep 21, 2022

View reviewed changes

mjkkirschner approved these changes Sep 21, 2022

View reviewed changes

aparajit-pratap reviewed Sep 21, 2022

View reviewed changes

aparajit-pratap approved these changes Sep 21, 2022

View reviewed changes

pinzart90 merged commit 6edfa66 into RC2.16.1_master Sep 24, 2022

pinzart90 deleted the fix_analytics_2.16 branch September 24, 2022 18:38

pinzart90 added a commit that referenced this pull request Jun 16, 2023

cherry pick analytics issue (#13328)

6f9761d

* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]>

pinzart90 added a commit that referenced this pull request Jun 16, 2023

Revert "cherry pick analytics issue (#13328)"

ab26213

This reverts commit 6f9761d.

pinzart90 added a commit that referenced this pull request Jun 16, 2023

cherry pick analytics issue (#13328)

fc53678

* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]>

QilongTang pushed a commit that referenced this pull request Jun 16, 2023

cherry pick analytics issue (#13328) (#14085)

3183671

* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]>

sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Sep 8, 2023

cherry pick analytics issue (DynamoDS#13328)

a28eb87

* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]>

mjkkirschner pushed a commit that referenced this pull request Sep 8, 2023

cherry pick analytics issue (#13328)

f799885

* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]>

mjkkirschner pushed a commit that referenced this pull request Sep 8, 2023

Revert "cherry pick analytics issue (#13328)"

97fe2f8

This reverts commit 6f9761d.

mjkkirschner pushed a commit that referenced this pull request Sep 8, 2023

cherry pick analytics issue (#13328) (#14085)

09212a0

* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cherry pick analytics issue#13328

cherry pick analytics issue#13328
pinzart90 merged 5 commits intoRC2.16.1_masterfrom
fix_analytics_2.16

pinzart90 commented Sep 21, 2022

Uh oh!

mjkkirschner Sep 21, 2022

Uh oh!

pinzart90 Sep 23, 2022

Uh oh!

mjkkirschner Sep 24, 2022

Uh oh!

mjkkirschner Sep 21, 2022

Uh oh!

QilongTang Sep 21, 2022 •

edited

Loading

Uh oh!

mjkkirschner left a comment

Uh oh!

aparajit-pratap Sep 21, 2022

Uh oh!

mjkkirschner Sep 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -1,4 +1,4 @@
		DYNAMO v.2.15.0 © 2022 Autodesk, Inc. All rights reserved.
		DYNAMO v.2.16.1 © 2022 Autodesk, Inc. All rights reserved.

Conversation

pinzart90 commented Sep 21, 2022

Purpose

Declarations

Release Notes

Reviewers

FYIs

Uh oh!

mjkkirschner Sep 21, 2022

Choose a reason for hiding this comment

Uh oh!

pinzart90 Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

mjkkirschner Sep 24, 2022

Choose a reason for hiding this comment

Uh oh!

mjkkirschner Sep 21, 2022

Choose a reason for hiding this comment

Uh oh!

QilongTang Sep 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjkkirschner left a comment

Choose a reason for hiding this comment

Uh oh!

aparajit-pratap Sep 21, 2022

Choose a reason for hiding this comment

Uh oh!

mjkkirschner Sep 22, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

QilongTang Sep 21, 2022 •

edited

Loading