[Trial PR] Remove await in WebView2 initialization#13295
Closed
QilongTang wants to merge 5 commits intoDynamoDS:masterfrom
RobertGlobant20:RemoveAwait
Closed
[Trial PR] Remove await in WebView2 initialization#13295QilongTang wants to merge 5 commits intoDynamoDS:masterfrom RobertGlobant20:RemoveAwait
QilongTang wants to merge 5 commits intoDynamoDS:masterfrom
RobertGlobant20:RemoveAwait
Conversation
Added code for create the WebView2 cache folder in the AppData location because when tries to create it inside C:\Program Files\Autodesk\Revit 2023\AddIns\DynamoForRevit is crashing due to permissions.
I added some code for stopping the WebView2 instance when Dynamo is being closed because otherwise is crashing and also not loading the notifications. Also the Dispose method was deleted due that we are doing the same in the new method added SuspendCoreWebviewAsync.
…github.com/RobertGlobant20/Dynamo into DYN-5245-Revit-NotificationCenter-Crashing
8 tasks
Contributor
Author
|
Unit tests passing with |
Contributor
Author
|
Closing this since proved that removing await will unblock the jobs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Remove await in WebView2 initialization to see if this removes CI regressions
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of