Add editorconfig by avidit · Pull Request #13233 · DynamoDS/Dynamo

avidit · 2022-08-22T19:29:41Z

Please Note:

Before submitting the PR, please review How to Contribute to Dynamo
Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
PRs will be reviewed from oldest to newest
If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Add editorconfig

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated

Release Notes

Add editorconfig

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

QilongTang · 2022-09-19T16:12:37Z

@avidit Does editorconfig apply to visual studio or code only or both?

avidit · 2022-09-19T17:08:39Z

@avidit Does editorconfig apply to visual studio or code only or both?

@QilongTang In code, it applies if EditorConfig for VS Code extension is installed.
In visual studio, it applies when we run Code Cleanup (Ctrl+K, Ctrl+E)

QilongTang · 2022-09-21T17:34:45Z

README.md

 ![Dynamo-VS2019Build](https://github.com/DynamoDS/Dynamo/workflows/Dynamo-VS2019Build/badge.svg)

+[![Nuget](https://img.shields.io/nuget/v/DynamoVisualProgramming.Core?logo=nuget)](https://www.nuget.org/packages/DynamoVisualProgramming.Core)
+[![DynamoVisualProgramming.Core on fuget.org](https://www.fuget.org/packages/DynamoVisualProgramming.Core/badge.svg)](https://www.fuget.org/packages/DynamoVisualProgramming.Core)


@avidit @mjkkirschner Is it fine for us to reference fuget on our readme?

yes I think so besides it being down a bunch.

QilongTang · 2022-09-21T17:35:25Z

src/AssemblySharedInfoGenerator/AssemblySharedInfo.cs

@@ -1,17 +1,18 @@
-using System;
+
+using System;


Why extra line above?

I think it is there because of the template directive in Line #1 of the AssemblySharedInfo.tt

QilongTang · 2022-09-21T17:36:20Z

.editorconfig

+insert_final_newline = true
+
+[*.tt]
+insert_final_newline = false


Are these based on our coding standards from our public wiki? Please confirm

Are these based on our coding standards from our public wiki? Please confirm

It doesn't look like it will contradict any of out Coding-Standards

QilongTang

A few comments then LGTM

QilongTang · 2022-09-22T14:32:55Z

Since this PR will impact all Dynamo teams, would love confirmation from other side. @aparajit-pratap @mjkkirschner @sm6srw @pinzart Please take a look

* add nunit test adapter for 2022 (#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (#13312) * Update Node AutoComplete Dialog Visuals (#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (#13233) * Dyn5272 (#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (#13338) passed here: merging. * Keep Node AutoComplete popup hidden when window deactivated (#13337) * Keep Node AutoComplete popup hidden when window deactivated * Add condition and null checks * comments Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]>

…3343) * add nunit test adapter for 2022 (#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (#13312) * Update Node AutoComplete Dialog Visuals (#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (#13233) * Dyn5272 (#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add some lacing tests that use arb rank params * fix tests 1. Missing replication Longest/Shortest attribute 2. Fix result - wrap in list (like old VM) Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]> Co-authored-by: kirschm <[email protected]>

* add nunit test adapter for 2022 (#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (#13312) * Update Node AutoComplete Dialog Visuals (#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (#13233) * Dyn5272 (#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add replication test * fix merge conflict * fix merge conflict Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: kirschm <[email protected]>

* add nunit test adapter for 2022 (#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (#13312) * Update Node AutoComplete Dialog Visuals (#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (#13233) * Dyn5272 (#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add replication test * fix merge conflict * fix merge conflict * update replication test Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: kirschm <[email protected]>

…namoDS#13343) * add nunit test adapter for 2022 (DynamoDS#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (DynamoDS#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (DynamoDS#13312) * Update Node AutoComplete Dialog Visuals (DynamoDS#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (DynamoDS#13233) * Dyn5272 (DynamoDS#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (DynamoDS#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (DynamoDS#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add some lacing tests that use arb rank params * fix tests 1. Missing replication Longest/Shortest attribute 2. Fix result - wrap in list (like old VM) Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]> Co-authored-by: kirschm <[email protected]>

* add nunit test adapter for 2022 (DynamoDS#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (DynamoDS#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (DynamoDS#13312) * Update Node AutoComplete Dialog Visuals (DynamoDS#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (DynamoDS#13233) * Dyn5272 (DynamoDS#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (DynamoDS#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (DynamoDS#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add replication test * fix merge conflict * fix merge conflict Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: kirschm <[email protected]>

* add nunit test adapter for 2022 (DynamoDS#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (DynamoDS#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (DynamoDS#13312) * Update Node AutoComplete Dialog Visuals (DynamoDS#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (DynamoDS#13233) * Dyn5272 (DynamoDS#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (DynamoDS#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (DynamoDS#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add replication test * fix merge conflict * fix merge conflict * update replication test Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: kirschm <[email protected]>

Add editorconfig

d34d487

QilongTang reviewed Sep 21, 2022

View reviewed changes

QilongTang approved these changes Sep 22, 2022

View reviewed changes

pinzart90 approved these changes Sep 22, 2022

View reviewed changes

sm6srw approved these changes Sep 22, 2022

View reviewed changes

aparajit-pratap approved these changes Sep 22, 2022

View reviewed changes

QilongTang merged commit 2e7c3a0 into DynamoDS:master Sep 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add editorconfig#13233

Add editorconfig#13233
QilongTang merged 1 commit intoDynamoDS:masterfrom
avidit:master

avidit commented Aug 22, 2022 •

edited by QilongTang

Loading

Uh oh!

QilongTang commented Sep 19, 2022

Uh oh!

avidit commented Sep 19, 2022

Uh oh!

QilongTang Sep 21, 2022

Uh oh!

mjkkirschner Sep 22, 2022

Uh oh!

QilongTang Sep 21, 2022

Uh oh!

avidit Sep 22, 2022

Uh oh!

QilongTang Sep 21, 2022

Uh oh!

avidit Sep 22, 2022

Uh oh!

QilongTang left a comment

Uh oh!

QilongTang commented Sep 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

avidit commented Aug 22, 2022 • edited by QilongTang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Declarations

Release Notes

Reviewers

FYIs

Uh oh!

QilongTang commented Sep 19, 2022

Uh oh!

avidit commented Sep 19, 2022

Uh oh!

QilongTang Sep 21, 2022

Choose a reason for hiding this comment

Uh oh!

mjkkirschner Sep 22, 2022

Choose a reason for hiding this comment

Uh oh!

QilongTang Sep 21, 2022

Choose a reason for hiding this comment

Uh oh!

avidit Sep 22, 2022

Choose a reason for hiding this comment

Uh oh!

QilongTang Sep 21, 2022

Choose a reason for hiding this comment

Uh oh!

avidit Sep 22, 2022

Choose a reason for hiding this comment

Uh oh!

QilongTang left a comment

Choose a reason for hiding this comment

Uh oh!

QilongTang commented Sep 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

avidit commented Aug 22, 2022 •

edited by QilongTang

Loading