Revert "setting exit tour method to internal and calling it when a new workspace is set" (#13180)#13204
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Aug 11, 2022
Merged
Conversation
…w workspace is set (DynamoDS#13180)" This reverts commit 5d18d76.
Collaborator
Author
Collaborator
Author
|
I think that the tests were failing because ExitGuidedTourIfOpened is called everytime a workspace a changed. To avoid that, changed the condition to call that method only in non-test mode. All the tests now pass on master-15: https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1068/ |
QilongTang
approved these changes
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
After some testing, I found that the self-serve tests on master-15 are failing due to this change:
#13180
Comparison:
Master(head pointing to: #13178): https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1066/ has -500 failing tests.
Master(with reverting #13180) https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1065/ passing all tests.
I am not exactly sure why all the json serialization tests are failing in this case. I think, there is one test failing which is causing all those failures but I cannot pin-point it yet. Looking more into it.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@filipeotero @QilongTang @mjkkirschner