Handling the Custom Nodes and Trusted Location message#13138
Handling the Custom Nodes and Trusted Location message#13138QilongTang merged 10 commits intoDynamoDS:masterfrom jesusalvino:DYN-5089-Trusted-Location-Crash
Conversation
|
|
|
Although this change is good, I don't think we should display trust warning in the bug senario from the first place. Can you hide the trust warning when switching to a different workspace which is a custom node workspace? |
|
| { | ||
| hsvm.DynamoViewModel.FileTrustViewModel.ShowWarningPopup = false; | ||
| hsvm.ClearWarning(); | ||
| } |
There was a problem hiding this comment.
hmm why do we need to touch this piece of code?
There was a problem hiding this comment.
it forces to hide the untrusted message and bubble when we start to work in a just created custom node workspace, not only when we switch the workspaces.
| if(IsHomeSpace && !IsCurrentSpace) | ||
| { | ||
| SetCurrentWarning(NotificationLevel.Mild, string.Empty); | ||
| DynamoViewModel.FileTrustViewModel.ShowWarningPopup = false; |
There was a problem hiding this comment.
From the gif, there will be a flash of trust warning displayed then disappear.. Less desirable, can we hide it even earlier?
There was a problem hiding this comment.
I dont think we still need this fix here in addition to other changes?
|
@jesusalvino Nice tries but I would love something more granular, for example, you can touch the visibility at https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs#L220 before executing the command to switch tabs. Or you can subscribe to |
Done
|
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
Looks much cleaner, LGTM once the remaining comments addressed
Done |
|
|
||
| private void DynamoViewModel_PropertyChanged(object sender, PropertyChangedEventArgs e) | ||
| { | ||
| if (e.PropertyName == "CurrentSpace" && !(sender as DynamoViewModel).ViewingHomespace) |
There was a problem hiding this comment.
use nameof to avoid spelling mistakes and make refactoring easier.
There was a problem hiding this comment.
use
nameofto avoid spelling mistakes and make refactoring easier.
Done
There was a problem hiding this comment.
@QilongTang Kindly, Could you let me know if we have any pending here please ?
|
Waiting for PR checks and also checking @jesusalvino is the last gif still valid? |
yes, the last gif is valid since the behavior is the same with the refactoring |
3 participants
Purpose
Handling the Trusted location message when a custom node space is opened.
https://jira.autodesk.com/browse/DYN-5089
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@RobertGlobant20 @filipeotero