Skip to content

DYN-5084 Checking if the ports are empty or null#13122

Merged
reddyashish merged 3 commits intoDynamoDS:masterfrom
filipeotero:DYN-5084-ColorPort-Nodes
Jul 22, 2022
Merged

DYN-5084 Checking if the ports are empty or null#13122
reddyashish merged 3 commits intoDynamoDS:masterfrom
filipeotero:DYN-5084-ColorPort-Nodes

Conversation

@filipeotero
Copy link
Contributor

@filipeotero filipeotero commented Jul 18, 2022

Purpose

This Pr includes the improvement for some edge cases where the Inports/Outports are wrongly colored when run at manual mode.

Ex2

Ex1

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang @Amoursol

@reddyashish
Copy link
Collaborator

reddyashish commented Jul 19, 2022

I have a question about the second gif in description. When the connector for watch node is removed, shouldn't the port show the red color as it is missing the value.

@filipeotero
Copy link
Contributor Author

filipeotero commented Jul 19, 2022

I have a question about the second gif in description. When the connector for watch node is removed, shouldn't the port show the red color as it is missing the value.

Hi, thanks for noticing that. This was happening because the watch node was having the same behavior of a function node.
According to the AC's of the DYN-5084, watch node shouldn't show grey bars under any circumstances.
By that, I've added a check specifically for the watch nodes.

@reddyashish
Copy link
Collaborator

reddyashish commented Jul 21, 2022

I agree on the grey bar. I was just not clear what the red color bar on the port indicate? Missing the value or something else?

@filipeotero
Copy link
Contributor Author

filipeotero commented Jul 21, 2022

I agree on the grey bar. I was just not clear what the red color bar on the port indicate? Missing the value or something else?

Yes. It indicates when the port has no values.

reddyashish
reddyashish reviewed Jul 22, 2022
View reviewed changes
reddyashish
reddyashish approved these changes Jul 22, 2022
View reviewed changes
Copy link
Collaborator

@reddyashish reddyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.

@reddyashish reddyashish merged commit 6a97e73 into DynamoDS:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

@reddyashish reddyashish reddyashish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@filipeotero @reddyashish @QilongTang