Skip to content

Cache if package maintainer is an author of the package to avoid multiple API calls#13111

Merged
zeusongit merged 1 commit intoDynamoDS:masterfrom
zeusongit:maintner
Jul 18, 2022
Merged

Cache if package maintainer is an author of the package to avoid multiple API calls#13111
zeusongit merged 1 commit intoDynamoDS:masterfrom
zeusongit:maintner

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Jul 14, 2022

Purpose

https://jira.autodesk.com/browse/DYN-5103

When a user right clicks a package in Dynamo package manager preference tab, we check if the user is an author of that package or not in order to enable/disable Deprecate/Undeprecate option for that package.

Created a cache in Dynamo to record the result so that we do not call the API again and again for one session.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Created a cache in Dynamo to record the result so that we do not call the API again and again for one session.

Reviewers

@QilongTang

@zeusongit zeusongit changed the title Update PackageManagerClient.cs Cache if package maintainer is an author of the package to avoid multiple API calls Jul 14, 2022
@mjkkirschner
Copy link
Member

mjkkirschner commented Jul 14, 2022

do we check this again / refresh if the user logs out / logs in as another user?

@zeusongit
Copy link
Contributor Author

zeusongit commented Jul 14, 2022

do we check this again / refresh if the user logs out / logs in as another user?

Not tested that scenario in revit, but it will break in that case, as Dictionary will have stale values.
Can user remain in Dynamo and logout? Because if it needs a restart then this could work.
I will test this and update.

QilongTang
QilongTang reviewed Jul 14, 2022
View reviewed changes
QilongTang
QilongTang reviewed Jul 14, 2022
View reviewed changes
@zeusongit
Copy link
Contributor Author

zeusongit commented Jul 14, 2022 •
edited
Loading

I checked in Revit, we cannot sign out without quitting, not sure about other integrators. @mjkkirschner

Screen Shot 2022-07-14 at 4 03 39 PM
.

QilongTang
QilongTang reviewed Jul 14, 2022
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM does it make sense to add a unit test for this update?

@zeusongit
Copy link
Contributor Author

zeusongit commented Jul 18, 2022

LGTM does it make sense to add a unit test for this update?

Unit test is not helpful, as we call the parent method for result, internally it uses cached or API response, with no way of knowing the difference.

@QilongTang QilongTang added this to the 2.16.0 milestone Jul 18, 2022
@zeusongit zeusongit merged commit 2232793 into DynamoDS:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.16.0

Development

Successfully merging this pull request may close these issues.

3 participants

@zeusongit @mjkkirschner @QilongTang