Skip to content

Pin Wire from Right-click Context Menu#13102

Merged
reddyashish merged 6 commits intoDynamoDS:masterfrom
dnenov:dnenov-impr-pin-interactions
Jul 20, 2022
Merged

Pin Wire from Right-click Context Menu#13102
reddyashish merged 6 commits intoDynamoDS:masterfrom
dnenov:dnenov-impr-pin-interactions

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Jul 12, 2022 •
edited
Loading

Purpose

An additional feature to the context menu of the connection wire. When Right-clicked, now will display the option to Pin wire

pin right-click context

A new set of Context Menu Items to allow the user to Show/Hide all Wires (connectors) from a group of selected Nodes.

  • if all wires are visible, the 'Hide All Wires' is active, 'Show All Wires' is inactive
  • if all wires are hidden, the 'Show All Wires' is active, 'Hide All Wires' is inactive
  • if some wires are visible and some hidden, both items are active

show hide wires
show hide wires 2

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • added right-click context menu to allow Pin wire
  • the wire will be pinned at the mouse point, similar to the existing mouse hoover behavior

Reviewers

@reddyashish

FYIs

@Amoursol

@dnenov
Pin Wire from Right-click Context Menu
7f0157c 
- added the ability to pin a wire from the right-click context menu
- the 'Pin' functionality already exists from the mouse-hoover behavior
@reddyashish reddyashish marked this pull request as ready for review July 12, 2022 17:53
@reddyashish
Copy link
Collaborator

reddyashish commented Jul 13, 2022

CI passed: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/6417/

@dnenov
Infrastructure Completed, Missing API Method
a662022 
- created the infrastructure for the Show/Hide All Wires context menu commands
- still missing the correct API to perform the required action
@reddyashish
Copy link
Collaborator

reddyashish commented Jul 18, 2022 •
edited
Loading

@dnenov Thanks, can you also add the a snapshot of the new changes.

dnenov added 3 commits July 18, 2022 17:41
@dnenov
ShowHideWires Working
9d6475e 
- both show and hide routine now operate directly on the IsHidden property of the ConnectorModel
@dnenov
Tests Added
0529fbb 
- added a test to check if the menu items are loaded
- added a test to check the functionality of Show/Hide All Wires commands
- added a test file
@dnenov
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into dnen…
b0754ee 
…ov-impr-pin-interactions
reddyashish
reddyashish reviewed Jul 20, 2022
View reviewed changes
@dnenov
Minor Iteration Change
0e90ff9 
- swapped Enumerator with ForEach for potential performance purposes
@reddyashish reddyashish merged commit a0fc6af into DynamoDS:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reddyashish reddyashish reddyashish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnenov @reddyashish