Optimize getting common base class for types in an array#13079
Merged
aparajit-pratap merged 1 commit intoDynamoDS:masterfrom Jul 1, 2022
Merged
Optimize getting common base class for types in an array#13079aparajit-pratap merged 1 commit intoDynamoDS:masterfrom
aparajit-pratap merged 1 commit intoDynamoDS:masterfrom
Conversation
mjkkirschner
approved these changes
Jul 1, 2022
Member
mjkkirschner
left a comment
There was a problem hiding this comment.
It looks good, but perhpas something is up with the test job not setting github checks correctly - has this passed yet?
pinzart90
approved these changes
Jul 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
ArrayUtils.GetTypeStatisticsForArrayused to unnecessarily be called twice in a few callers, once outside and once inside the call toGetCommonSubClassForArray. This PR refactors the code so that the type stats fromGetTypeStatisticsForArraycan be passed into the method that returns the common base type if the type stats are already computed.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Performance optimization in determining types in arrays.