DYN-5018 Collapsed group moving fix#13073
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Jun 29, 2022
Merged
Conversation
Contributor
|
Is there a Jira task linked or just a bug you found? |
Contributor
Author
It's a bug that Aabi found related to the task DYN-5018 |
QilongTang
reviewed
Jun 29, 2022
| else | ||
| { | ||
| //If the annotation is not expanded, than it will remain the same width of the last time it was expanded | ||
| Width = lastExpandedWidth; |
Contributor
There was a problem hiding this comment.
Would there be any edge case that the new width should not be set to last expanded width?
Contributor
There was a problem hiding this comment.
Thinking about it, maybe no edge case since we currently disable adding new elements into group when it is collapsed
Contributor
Author
There was a problem hiding this comment.
That's right, the width will be the same when the group is collapsed.
zeusongit
reviewed
Jun 29, 2022
| } | ||
| else | ||
| { | ||
| //If the annotation is not expanded, than it will remain the same width of the last time it was expanded |
Contributor
There was a problem hiding this comment.
than -> then
expanded, then it will
QilongTang
approved these changes
Jun 29, 2022
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM once comments addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is to fix the bug when the user moves a collapsed group horizontally.
The issue was occurring because of an unusual change in the width value. To fix that was created a variable to keep the previous value of the group's width when collapsed.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @pinzart