cherry pick raise notification at startup if installed package targets a different host#13010
Merged
mjkkirschner merged 1 commit intoDynamoDS:RC2.15.0_masterfrom Jun 15, 2022
Merged
Conversation
…t host. (DynamoDS#12990) * add notifications for packages with other host at startup time refactor where check is fix existing tests * fix and better notification * add test * fix tests * comments * Update PackageManagerExtension.cs * Update PackageManagerViewExtensionTests.cs * typo * also check hosts at package load add test
QilongTang
approved these changes
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
(#12990)
add notifications for packages with other host at startup time
refactor where check is
fix existing tests
fix and better notification
add test
fix tests
comments
Update PackageManagerExtension.cs
Update PackageManagerViewExtensionTests.cs
typo
also check hosts at package load
add test
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
raise warning at package load if package targets a different host than dynamo's current execution host.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of