DYN-4973-Popups-NotAttached#13002
Merged
QilongTang merged 8 commits intoDynamoDS:masterfrom Jun 16, 2022
RobertGlobant20:DYN-4973-Popups-NotAttached
Merged
DYN-4973-Popups-NotAttached#13002QilongTang merged 8 commits intoDynamoDS:masterfrom RobertGlobant20:DYN-4973-Popups-NotAttached
QilongTang merged 8 commits intoDynamoDS:masterfrom
RobertGlobant20:DYN-4973-Popups-NotAttached
Conversation
I implemented the functionality of hiding/showing the FileTrustUI and GuidedTours popups when the Dynamo window is inactive (in background). I've tested the functionality for the User Interface tour and Packages tour and for the exitwindow that appear in the Packages tour. For the other tours the RealTimeWindow (that appear when exiting the Guide) wont' have this functionality implemented.
Contributor
Author
|
This GIF shows the functionality for the Popups in the Guided Tour |
Contributor
Author
|
This GIF shows the functionality for the Popup in the FileTrustUI |
Contributor
|
Does this also fix toast notifications, are they also attached to parent window now? |
Contributor
Author
@zeusongit
For the RealTimeInfo popup I think @QilongTang changed the StaysOpen property in a different PR then it should be closing the Popup when the focus is lost.
|
QilongTang
reviewed
Jun 14, 2022
QilongTang
reviewed
Jun 14, 2022
I removed all the functionality of setting a state in the Guide and also added a new event for when the tour is completely closed (just in the case of the Packages guide).
QilongTang
reviewed
Jun 15, 2022
QilongTang
reviewed
Jun 15, 2022
QilongTang
reviewed
Jun 15, 2022
Changed the hard-coded string to use the static string
QilongTang
reviewed
Jun 15, 2022
QilongTang
reviewed
Jun 15, 2022
QilongTang
reviewed
Jun 15, 2022
QilongTang
reviewed
Jun 15, 2022
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
Some comments, then LGTM
Event renamed from GuidedTourClosed to GuidedTourFinished. The property warningPopup was renamed to fileTrustWarningPopup.
Event renamed from GuidedTourFinished to GuidedTourExited
Fixing function name to match event name.
Removed subscriptions to GuidedTourExited event and the empty function handler.
reddyashish
reviewed
Jun 16, 2022
Renaming property to IsGuideExited
QilongTang
approved these changes
Jun 16, 2022
reddyashish
approved these changes
Jun 16, 2022
8 tasks
8 tasks
QilongTang
pushed a commit
that referenced
this pull request
Jun 29, 2022
After the changes done in the next PR: #13002 I introduced a bug that was not allowing to save the path added in trusted locations, then with this fix is saving again the trusted locations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
I implemented the functionality of hiding/showing the FileTrustUI and GuidedTours popups when the Dynamo window is inactive (in background).
I've tested the functionality for the User Interface tour and Packages tour and for the exitwindow that appear in the Packages tour.
For the other tours the RealTimeWindow (that appear when exiting the Guide) wont' have this functionality implemented.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
I implemented the functionality of hiding/showing the FileTrustUI and GuidedTours popups when the Dynamo window is inactive.
Reviewers
@QilongTang
FYIs