Skip to content

DYN-4997 Add Trust Location Added/Skipped Notification#12970

Merged
QilongTang merged 6 commits intomasterfrom
AddTrustedNotification
Jun 7, 2022
Merged

DYN-4997 Add Trust Location Added/Skipped Notification#12970
QilongTang merged 6 commits intomasterfrom
AddTrustedNotification

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jun 7, 2022 •
edited
Loading

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Per https://jira.autodesk.com/browse/DYN-4997, add trust location added/ skipped notification

Trust location added with trust warning check box:
image

When user click No and close the file
image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Add trust location added/ skipped notification

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 2.15.0 milestone Jun 7, 2022
zeusongit
zeusongit reviewed Jun 7, 2022
View reviewed changes
src/DynamoCoreWpf/Views/FileTrust/FileTrustWarning.xaml.cs Outdated
if (dynViewModel.CloseHomeWorkspaceCommand.CanExecute(null))
{
dynViewModel.CloseHomeWorkspaceCommand.Execute(null);
dynViewModel.MainGuideManager.CreateRealTimeInfoWindow(string.Format(Properties.Resources.TrustLocationSkippedNotification, fileTrustWarningViewModel.DynFileDirectoryName));
Copy link
Contributor

@zeusongit zeusongit Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a todo, or file a task to make this API generic?

@zeusongit
Copy link
Contributor

zeusongit commented Jun 7, 2022

Does this banner also has the bug, where it is not bound to the parent window?
DynamoSandbox_VrSviTOFhw

@QilongTang
Copy link
Contributor Author

QilongTang commented Jun 7, 2022 •
edited
Loading

Does this banner also has the bug, where it is not bound to the parent window?

Yes, a lot of Dynamo UI components come with such bug

@QilongTang QilongTang marked this pull request as ready for review June 7, 2022 14:35
@QilongTang QilongTang requested a review from reddyashish June 7, 2022 14:36
@QilongTang
Copy link
Contributor Author

QilongTang commented Jun 7, 2022

Added one small fix to reset run status message in Manual mode.

@QilongTang
Copy link
Contributor Author

QilongTang commented Jun 7, 2022

Updated the messages so graph in Manual mode is expected to not run. FYI: @Amoursol
image

@QilongTang
Copy link
Contributor Author

QilongTang commented Jun 7, 2022

No real regressions on job https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/6338/

@QilongTang
Copy link
Contributor Author

QilongTang commented Jun 7, 2022

@zeusongit @reddyashish This PR is ready for a final look

@QilongTang QilongTang merged commit 5510620 into master Jun 7, 2022
@QilongTang QilongTang deleted the AddTrustedNotification branch June 7, 2022 18:33
@chubakueno chubakueno mentioned this pull request Nov 5, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeusongit zeusongit zeusongit approved these changes

@reddyashish reddyashish reddyashish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

3 participants

@QilongTang @zeusongit @reddyashish