Skip to content

Type Identifiers in preview bubble and watch node.#12950

Merged
QilongTang merged 6 commits intoDynamoDS:masterfrom
reddyashish:master
Jun 6, 2022
Merged

Type Identifiers in preview bubble and watch node.#12950
QilongTang merged 6 commits intoDynamoDS:masterfrom
reddyashish:master

Conversation

@reddyashish
Copy link
Collaborator

@reddyashish reddyashish commented Jun 1, 2022 •
edited
Loading

Purpose

This PR is to implement type identifiers for the data in preview bubble and watch node.

Task: https://jira.autodesk.com/browse/DYN-3416

Screen Shot 2022-06-06 at 9 40 27 AM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Type Identifiers in preview bubble and watch node.

Reviewers

@QilongTang @zeusongit

@reddyashish reddyashish added the WIP label Jun 1, 2022
@reddyashish
Copy link
Collaborator Author

reddyashish commented Jun 1, 2022

Fixing the regressions

@reddyashish reddyashish removed the WIP label Jun 6, 2022
@reddyashish
Copy link
Collaborator Author

reddyashish commented Jun 6, 2022

All tests passing now.

@QilongTang
Copy link
Contributor

QilongTang commented Jun 6, 2022

Taking a look now

@QilongTang QilongTang added this to the 2.15.0 milestone Jun 6, 2022
QilongTang
QilongTang reviewed Jun 6, 2022
View reviewed changes
QilongTang
QilongTang reviewed Jun 6, 2022
View reviewed changes
QilongTang
QilongTang reviewed Jun 6, 2022
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments then LGTM

QilongTang
QilongTang approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @zeusongit what do you think?

@mjkkirschner
Copy link
Member

mjkkirschner commented Jun 6, 2022 •
edited
Loading

@QilongTang - @reddyashish - just a thought, have you considered using a feature flag to control this feature in case there are performance issues with large data sets? Then we could disable it after release or after longer testing cycle.

@reddyashish
Copy link
Collaborator Author

reddyashish commented Jun 6, 2022 •
edited
Loading

@mjkkirschner Simulated the watch node with large lists and did not notice any difference. Do you mind if I add that in a followup task once we test it in bug-bash?

@QilongTang QilongTang merged commit 6243504 into DynamoDS:master Jun 6, 2022
@reddyashish
Copy link
Collaborator Author

reddyashish commented Jun 6, 2022

Created a spike to investigate other cases for any performance drop. https://jira.autodesk.com/browse/DYN-5010

@reddyashish reddyashish mentioned this pull request Jun 6, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

@zeusongit zeusongit zeusongit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

4 participants

@reddyashish @QilongTang @mjkkirschner @zeusongit