Merged
Conversation
- fixed an issue where a previously selected Node will get the target for re-pinning after Undo - small clean-up from existing code
- attempt to fix multiple unit tests failing
Collaborator
|
All tests passed on master-15. Opening this PR |
1 similar comment
Collaborator
|
All tests passed on master-15. Opening this PR |
reddyashish
approved these changes
May 31, 2022
Collaborator
|
@QilongTang @zeusongit Merging this. Let me know if you have any concerns. |
Contributor
|
@reddyashish Can you assign the related Jira task to test? Is it DYN-4828? |
Collaborator
|
Yes. Will update the task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is a minor Bug fix. The ability to Redo after a Note has been Pinned to a Node and Undo is triggered.
Task: https://jira.autodesk.com/browse/DYN-4828
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
FYIs
@mjkkirschner
@Amoursol