Dyn 4843 watch node smaller#12855
Dyn 4843 watch node smaller#12855QilongTang merged 28 commits intoDynamoDS:masterfrom jesusalvino:DYN-4843-Watch-Node-Smaller
Conversation
Update from the main repository
|
|
|
@jesusalvino What is the real change here? Is it just 64608e0? If this is the case, next time please use a clean branch |
| { | ||
| if (_vm.Children != null) | ||
| { | ||
| if (!_vm.Children[0].IsCollection) |
There was a problem hiding this comment.
Can there be a case where _vm.Children.Count == 0 at this point ?
There was a problem hiding this comment.
I don't think so since I have tested with only a single line and multiple lines, for both cases the node has at least one element
| { | ||
| if (!_vm.Children[0].IsCollection) | ||
| { | ||
| double requiredWidth = (_vm.Children[0].NodeLabel.Length * 7.5); |
There was a problem hiding this comment.
Why 7.5 ?
A comment at least
There was a problem hiding this comment.
this is the width factor for each character, it has been approved / and evidenced here #12829, this current PR is focusing in the tests.
yes only the tests / for sure sorry for the confusion |
Can you add a comment just in case? Then let's wait for PR checks to finish. Thanks for the fix! |
|
@jesusalvino Please also resolve the conflict, this is also a side effect of not using clean branch |
Done |
3 participants
Purpose
Fixing the UI Tests based on the new WatchNode styling
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@RobertGlobant20 @filipeotero