Dyn 4843 watch node smaller#12829
Dyn 4843 watch node smaller#12829zeusongit merged 25 commits intoDynamoDS:masterfrom jesusalvino:DYN-4843-Watch-Node-Smaller
Conversation
Update from the main repository
|
FYI: @Amoursol @reddyashish Notes from standup, for single line of data, we should try to hide vertical scrollbar if possible |
| void WatchTree_Loaded(object sender, RoutedEventArgs e) | ||
| { | ||
| _vm = this.DataContext as WatchViewModel; | ||
| _vm.PropertyChanged += _vm_PropertyChanged; |
There was a problem hiding this comment.
can we unsubscribe this somehow?
QilongTang
left a comment
There was a problem hiding this comment.
Looks good on my side. @Amoursol how is the new look?
Looking much better for sure! Is it possible to also not have it quite as wide if we are returning a smaller digit like a 2? Also, @jesusalvino can you please make a quick GIF of also showcasing the following:
WatchNodeTesting.movThis will allow us to test a range of cases, and see how the node behaves. |
Done @Amoursol , notice the default width is 200, it turns dynamic according to the source |
|
@jesusalvino @Amoursol @QilongTang What do you think about setting a maximum width and having a horizontal scroll bar. The last case seems pretty wide. |
reddyashish
left a comment
There was a problem hiding this comment.
Looks good to me once we confirm the max width case.
|
Please confirm @Amoursol I also think the last case is too wide to display |
Agreed, it sounded good on paper but looks a bit wild in practice! Can we please go with a width that is reasonable, then the user can expand again? Worth testing = 2x the width of the watch node in 2.14 as a max stretch default. |
|
@Amoursol The max width of a Watch node will be its default 2X = 400, if the line exceeds it, the horizontal scrollbar will be available for the user |
This is looking AWESOME! Thank you @jesusalvino. Did you manage to have it not as wide when returning a small number such as |
yes |
Looks perfect to me - thank you! Consider it done from my side 😊 |





Purpose
Declarations
Check these if you believe they are true
*.resxfiles###Reviewers
@QilongTang
###FYIs
@RobertGlobant20 @filipeotero