Set the default color in the color palette when using node autocomplete.#12819
Merged
reddyashish merged 2 commits intoDynamoDS:masterfrom Apr 26, 2022
Merged
Set the default color in the color palette when using node autocomplete.#12819reddyashish merged 2 commits intoDynamoDS:masterfrom
reddyashish merged 2 commits intoDynamoDS:masterfrom
Conversation
Contributor
|
I am fine with this being a temp fix, it seems this issue exist for all node customization applied to node from autocomplete though. @zeusongit what do you think? |
Contributor
|
I think the fix is good enough for now, but we should file a task to handle the exception and not add another undo recorder that throws the exception. |
Collaborator
Author
|
@QilongTang @zeusongit I have removed that API call and tested it locally. This is specific to the color palette node. |
Collaborator
Author
QilongTang
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is a followup to the task: https://jira.autodesk.com/browse/DYN-4753.
When the color palette node is placed using the node autocomplete, the default color(black) was not being set.
The reason for this was that there was an exception being thrown in here: https://github.com/DynamoDS/Dynamo/blob/master/src/Libraries/CoreNodeModelsWpf/NodeViewCustomizations/ColorPalette.cs#L42 and the view customization would not finish.
The exception is a custom one that is related to UndoRedo operation:
Dynamo/src/DynamoCore/Core/UndoRedoRecorder.cs
Line 267 in a496720
The undo redo operation around this node works fine and I see this WorkspaceModel.RecordModelForModification() being called only for couple other nodes. There is a TODO on that API, saying we should refactor that and move the code to the WorkspaceViewModel. For now, I made sure that this would be the last step in node view customization so that everything else will be executed even if this throws an exception. We could also catch this exception and handle it accordingly. Any thoughts?
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@QilongTang @zeusongit